Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify conventions around usage of big.Int #294

Open
fmoletta opened this issue Sep 26, 2023 · 0 comments
Open

Unify conventions around usage of big.Int #294

fmoletta opened this issue Sep 26, 2023 · 0 comments

Comments

@fmoletta
Copy link
Contributor

fmoletta commented Sep 26, 2023

Some functions use big.Int as arguments, while others use *big.Int. The same happens with scope variables, some hints store them as references while others store their value, which can lead to bugs in cross-hint interaction. We should have a unified criteria to avoid any kind of confusions.
I suggest sticking to *big.Int, as this is what all functions and methods in the big package use

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant