Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the no-op libfuncs cleaner #863

Open
edg-l opened this issue Oct 17, 2024 · 0 comments · May be fixed by #919
Open

Make the no-op libfuncs cleaner #863

edg-l opened this issue Oct 17, 2024 · 0 comments · May be fixed by #919
Assignees
@azteca1998
Labels
process Tasks related to the develop process, CI, testing, etc

Comments

@edg-l
Copy link
Collaborator

edg-l commented Oct 17, 2024

Some of the libfuncs, for one reason or another, are nops in native. It would make sense not to have a build function for each and instead just inline the nop as match arms (or a shared no-op libfunc).
@edg-l edg-l added enhancement New feature or request process Tasks related to the develop process, CI, testing, etc and removed enhancement New feature or request labels Oct 17, 2024
@azteca1998 azteca1998 self-assigned this Nov 13, 2024
@azteca1998 azteca1998 linked a pull request Nov 13, 2024 that will close this issue
Coalesce all compatible no-op libfuncs into a single function. #919
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@azteca1998 azteca1998

Labels
process Tasks related to the develop process, CI, testing, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Coalesce all compatible no-op libfuncs into a single function. lambdaclass/cairo_native
2 participants
@azteca1998 @edg-l