Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved changes to the zk tool #166

Open
mationorato opened this issue Feb 20, 2024 · 0 comments · May be fixed by #176
Open

Improved changes to the zk tool #166

mationorato opened this issue Feb 20, 2024 · 0 comments · May be fixed by #176
Assignees
Labels

Comments

@mationorato
Copy link
Collaborator

discussion: matter-labs#1015 (comment)

Validium introduces some changes to zk tool (init.ts mainly, but not related to it) that does not follow some common patters.

The new behavior is undocumented, does not follow hierarchical structure of the module.

Reuse the existing configuration subsystem as much as possible (consult ML if feeling stuck); document introduced changes; introduce changes according to the logical domain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants