Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move gas prices to be U256 to avoid overflows #200

Open
jrchatruc opened this issue Feb 29, 2024 · 0 comments
Open

Move gas prices to be U256 to avoid overflows #200

jrchatruc opened this issue Feb 29, 2024 · 0 comments
Assignees
@juan518munoz
Labels
erc20-base-token

Comments

@jrchatruc
Copy link
Collaborator

🌟 Feature Request

The minimal_l2_gas_price, l1_gas_price, and l1_pubdata_price variables are currently u64s, which is a problem especially now that they'll be denominated in a custom erc20 (overflows are a very real possibility). They have to be moved to be of type U256 to avoid any problems like it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@juan518munoz juan518munoz

Labels
erc20-base-token
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jrchatruc @juan518munoz