You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Description: There are a couple of typos in the functions' doc comments. Some of the require additional information:
Recommendation:
computeLine and mixedAdditionStep require that points in Jacobian coordinates are not equal. We recommend to mention and explain this why it's it's never a case in this implementation. We add and double point Q which is G2 group generator of an order of 21888242871839275222246405745257275088548364400416034343698204186575808495617. So will never reach Q``
g2ProjectiveFromAffine doc comment is wrong. It should be If x or y differ from 0, just add z = (1,0).
There is a mistake in MONTGOMERY_TWISTED_CURVE_COEFFS doc comment. Twisted curve equation is wrong. b coefficient should be 3/(9+u).
Wrong curve equation in g2AffinePointIsOnCurve doc comment
zkSync:
Spearbit:
The text was updated successfully, but these errors were encountered:
Context: EcPairing.yul
Description: There are a couple of typos in the functions' doc comments. Some of the require additional information:
Recommendation:
computeLine
andmixedAdditionStep
require that points in Jacobian coordinates are not equal. We recommend to mention and explain this why it's it's never a case in this implementation. We add and double pointQ
which isG2
group generator of an order of21888242871839275222246405745257275088548364400416034343698204186575808495617. So will never reach
Q``g2ProjectiveFromAffine
doc comment is wrong. It should be If x or y differ from 0, just add z = (1,0).b
coefficient should be3/(9+u)
.g2AffinePointIsOnCurve
doc commentzkSync:
Spearbit:
The text was updated successfully, but these errors were encountered: