Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Function g2JacobianAdd does not support same inputs #245

Closed
IAvecilla opened this issue Apr 12, 2024 · 0 comments · Fixed by #254
Closed

Function g2JacobianAdd does not support same inputs #245

IAvecilla opened this issue Apr 12, 2024 · 0 comments · Fixed by #254
Assignees
@IAvecilla

Comments

@IAvecilla
Copy link
Contributor

Context: EcPairing.yul#L501

Description: g2JacobianAdd requires inputs to be a two different points in Jacobian coordinates. It returns inf if they are the same.

Recommendation: Update doc comment of this function and stress this requirements. g2JacobianDouble should be used instead.

zkSync:

Spearbit:
@IAvecilla IAvecilla self-assigned this Apr 12, 2024
@IAvecilla IAvecilla mentioned this issue Apr 12, 2024
Merged
@IAvecilla IAvecilla linked a pull request Apr 12, 2024 that will close this issue
Fix functions doc #254
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@IAvecilla IAvecilla

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix functions doc lambdaclass/zksync_era_precompiles
1 participant
@IAvecilla