From 6be30bb44f192b17a6daaacc78cff69f0f1282ce Mon Sep 17 00:00:00 2001 From: Weston Pace Date: Fri, 5 Apr 2024 09:20:45 -0700 Subject: [PATCH] Remove unused options --- rust/lance-file/src/v2/writer.rs | 19 ------------------- 1 file changed, 19 deletions(-) diff --git a/rust/lance-file/src/v2/writer.rs b/rust/lance-file/src/v2/writer.rs index de7d30a6c6..6ff61dcf8b 100644 --- a/rust/lance-file/src/v2/writer.rs +++ b/rust/lance-file/src/v2/writer.rs @@ -23,13 +23,6 @@ use crate::format::MINOR_VERSION_NEXT; #[derive(Debug, Clone, Default)] pub struct FileWriterOptions { - /// The field ids to collect statistics for. - /// - /// If None, will collect for all fields in the schema (that support stats). - /// If an empty vector, will not collect any statistics. - /// - // TODO: Not yet implemented - pub collect_stats_for_fields: Option>, /// How many bytes to use for buffering column data /// /// When data comes in small batches the writer will buffer column data so that @@ -45,18 +38,6 @@ pub struct FileWriterOptions { /// The default will use 8MiB per column which should be reasonable for most cases. // TODO: Do we need to be able to set this on a per-column basis? pub data_cache_bytes: Option, - /// How many bytes to use for buffering data to write - /// - /// After data has been encoded it is placed into an I/O cache while we wait for it - /// to be written to disk. If data is arriving quickly and your I/O is very jittery - /// then you might want to increase this value. However, the default of 128MiB should - /// be sufficient for most cases. - /// - /// If data is arriving slowly or write speed is not important you can turn this down - /// all the way to zero to eliminate I/O caching entirely and free up some RAM. In this - /// mode each write will block until its data has been flushed. This prevents any - /// interleaving of encoding and writing. - pub io_cache_bytes: Option, } pub struct FileWriter {