Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: null support for plain encoding #1643

Open
Tracked by #2079
rok opened this issue Nov 20, 2023 · 4 comments
Open
Tracked by #2079

feat: null support for plain encoding #1643

rok opened this issue Nov 20, 2023 · 4 comments
Assignees

Comments

@rok
Copy link
Contributor

rok commented Nov 20, 2023

Subtask of #16.

Create proposal for nullability implementation with a mini batch binary mask.

@rok rok self-assigned this Nov 20, 2023
@rok rok removed their assignment Dec 21, 2023
@westonpace westonpace self-assigned this Jan 15, 2024
@westonpace
Copy link
Contributor

@wjones127 to answer your question regarding structs & nullability. I agree that we should not try and store nulls for structs. A null struct should become a struct of nulls. This matches our current I/O most closely and so it is the easier change. If we have a need for it we can add that in the future.

@dnsco
Copy link
Contributor

dnsco commented Jan 17, 2024

Weighing in as a user, being able to write queries in duckdb as "where some_struct is not null" is really nice. It is different than "where some_struct.some_field is not null".

I have no idea about the implementation implications on your side, but want to throw out that the former is really really nice.

@wjones127 wjones127 added this to the (WIP) Lance Roadmap milestone Mar 12, 2024
@wjones127 wjones127 mentioned this issue Mar 15, 2024
20 tasks
@mkleinbort
Copy link

Very keen on this feature, we'd like to move to lance but this is a deal breaker for our data infrastructure

@westonpace
Copy link
Contributor

Very keen on this feature, we'd like to move to lance but this is a deal breaker for our data infrastructure

It's in progress. Right now the plan is for it to be delivered as part of #1929 . I've been focused on lancedb/lancedb#926 recently but should be finishing up this week and getting some time to spend on Lance v2 again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants