Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[water] bad calibrations pass through qa/qc checks #31

Open
rfiorella opened this issue Feb 19, 2020 · 2 comments
Open

[water] bad calibrations pass through qa/qc checks #31

rfiorella opened this issue Feb 19, 2020 · 2 comments
Labels
bug Something isn't working

Comments

@rfiorella
Copy link
Collaborator

Bad calibration values are passed through qa/qc checks currently, and produce implausible (or impossible) isotope ratios.

@rfiorella rfiorella added the bug Something isn't working label Feb 19, 2020
@bumbanian
Copy link

Many of these would be identifiable w/ a screening criterion for slope and/or R^2. Should explore, but I expect ~0.9 - 1.1 is a reasonable range for the regression slope parameter. Maybe start there?

rfiorella added a commit that referenced this issue Feb 25, 2020
As noted in #31, bad calibrations pass through this script and are reflected in the calibrated data. Commit adds a requirement that R^2 must be above 0.9 to be used in calibration - though this might be too permissive.

@bumbanian suggested a slope check as well - will look through the sites to see if there's a suitable range that works for all sites. Given that NEON seems to calibrate the instrument's slope/intercept parameters at some frequency (once a year maybe?), the suggestion of a 0.9-1.1 tolerance might work.
@rfiorella
Copy link
Collaborator Author

Currently no r2 threshold in calibrate_ambient_water_isotopes - seems an obvious place to start to improve this, and would make code structure more consistent w/ carbon calibration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants