Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide default functionality for MinInternalEnergyFromDensity() #318

Closed
jhp-lanl opened this issue Oct 27, 2023 · 2 comments · May be fixed by #375
Closed

Provide default functionality for MinInternalEnergyFromDensity() #318

jhp-lanl opened this issue Oct 27, 2023 · 2 comments · May be fixed by #375
Labels
enhancement New feature or request

Comments

@jhp-lanl
Copy link
Collaborator

It might make sense to just use the zero K isotherm lookup as the minimum energy at least for thermodynamically consistent EOS.
@jhp-lanl jhp-lanl added the enhancement New feature or request label Oct 27, 2023
@jhp-lanl jhp-lanl mentioned this issue Oct 27, 2023
Merged
6 tasks
@jhp-lanl jhp-lanl mentioned this issue May 11, 2024
Draft
8 tasks
@Yurlungur
Copy link
Collaborator

Done. Provided in base class.

@jhp-lanl
Copy link
Collaborator Author

Well, technically this is really resolved by #375. The current default functionality is an error whereas that MR changes it to be in line with what I proposed here.

I'm not pedantic enough to re-open this though 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Create minimum energy modifier lanl/singularity-eos
2 participants
@Yurlungur @jhp-lanl