[11.x] Improve Schema::hasTable() performance
#53006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for submitting a PR! Note that draft PR's are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface. Pull requests that are abandoned in draft may be closed due to inactivity. |
hafezdivandari
changed the title
Schema::hasTable() performanceSchema::hasTable() performance
Vinksyunit
reviewed
Oct 1, 2024
|
Perfectly timed! I was working on a similar PR. Last week I upgraded a SaaS app and the migrations were taking around 3 minutes per tenant 😩 @hafezdivandari thanks for the PR, I really appreciate it!!! 👌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #53002
The
Schema::hasTable()method is using theSchema::getTable()method internally, which could sometimes result in an expensive query. This PR improves the performance ofSchema::hasTable()by using more lightweight queries.PS: I previously added many integration tests for these methods and their edge cases.