Rendering issue with long confirm labels

[duncanmcclean]

Laravel Prompts Version

0.1.16

Laravel Version

11.0.3

PHP Version

8.3.0

Operating System & Version

macOS 14.3.1

Terminal Application

iTerm & VS Code's integrated terminal

Description

We're migrating some of our commands to Laravel Prompts, now we no longer support PHP 8.1, they're all looking really nice, thanks for your hard work. 🪄

However, in converting one of our commands with a longish confirm label, I noticed an issue where the top right of the prompt isn't being rendered correctly:

I would assume the "border line" should connect to the "border lines" on the right.

Steps To Reproduce

1. Create a fresh Laravel application
2. Install Laravel Prompts
3. Add this command to your routes/console.php file:

Artisan::command('long-confirm-label', function () {
    $date = now()->format('Y-m-d');

    if (confirm("The current date is [<comment>{$date}</comment>]. The label for this prompt is very long. Is this okay?")) {
        $this->info('You chose to continue');
    } else {
        $this->info('You chose to cancel');
    }
});

Alternatively, I've also spun up a fresh Laravel 11 app which you can clone to replicate the issue.

[duncanmcclean]

I think it may be related to the [<comment>...</comment>] stuff we have going on. Removing that seems to sort it.

I'm new to Prompts, so if that syntax isn't intended to work, feel free to close this issue. Apologies for the time waste!

[jessarcher]

Hi @duncanmcclean,

I think it may be related to the [<comment>...</comment>] stuff we have going on. Removing that seems to sort it.

You are correct. So far we've only added support for Symfony's fg, bg, and options tags. E.g. <fg=yellow>{$date}</>.

I'm new to Prompts, so if that syntax isn't intended to work, feel free to close this issue. Apologies for the time waste!

I hadn't even considered some of the named styles like info, comment, etc! Definitely not a waste of time 🙂 It should be straightforward to support them, but supporting any custom-named styles would be more complex.

[jessarcher]

I've created #125 to address this!

[duncanmcclean]

Thanks for the quick fix! 🎉