Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate reducing terminal height requirements #127

Closed
jessarcher opened this issue Mar 19, 2024 · 1 comment · Fixed by #128
Closed

Investigate reducing terminal height requirements #127

jessarcher opened this issue Mar 19, 2024 · 1 comment · Fixed by #128
Assignees

Comments

@jessarcher
Copy link
Member

This is just a reminder for me to investigate whether we can reduce the terminal height requirements, which is mostly an issue in IDEs with a terminal drawer, especially if the font size or line height is increased.

image

This will be the most challenging for prompts like search and suggest as they have a label, text field, dropdown, and error message section, along with additional lines for drawing box characters.

The first thing to investigate is whether the blank lines before and after the prompt are counting towards the limit and whether they can be discounted. The blank line before will never change, so it can sit safely outside of the terminal view, and the blank line below can perhaps not be rendered until the prompt is completed.

Then, it would be good to investigate if the re-rendering process can take the terminal height into consideration and only re-render the visible lines. This will mean that if a prompt is only partially visible and you scroll back, it won't reflect the current rendered state, but if that is just the label, then it might be acceptable and preferable to not rendering at all. As far as I'm aware, we can't change anything in the scrollback area, and we want to ensure that if someone does scroll back, it doesn't show partial frames.

@jessarcher
Copy link
Member Author

Solved in #128

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant