Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vite 5 Support #265

Closed
driesvints opened this issue Nov 20, 2023 · 13 comments · Fixed by #269
Closed

Vite 5 Support #265

driesvints opened this issue Nov 20, 2023 · 13 comments · Fixed by #269
Assignees

Comments

@driesvints
Copy link
Member

We're working on Vite 5 support which is most likely to arrive somewhere next week.

@driesvints
Copy link
Member Author

Relevant: laravel/framework#49049

@Unnoen
Copy link

Unnoen commented Nov 23, 2023

Just copying this comment from laravel/framework#49049 (comment) by @gabrielrbarbosa for a simple fix.

I solved this by just editing vite.config.js, I think it may be easier to just add:

export default defineConfig({
  build: {
    manifest: 'manifest.json',
  },
});

The above is working for me with no noticeable issues.

@taylorotwell
Copy link
Member

We will get to this after Pulse is released this week.

@craigrileyuk
Copy link

@Unnoen

This works pretty well, but I'm getting a The "code" argument must be of type number. Received type string ('SIGINT') error when I exit dev mode, so it's not a perfect workaround.

@AntonOfTheWoods
Copy link

I agree it works "pretty well". Is there a list of things that need work?

@xsjcTony
Copy link

xsjcTony commented Dec 5, 2023

Any progress on this? Vitest released v1 and it requires vite v5 to work😥

@indy2kro
Copy link

indy2kro commented Dec 5, 2023

The "somewhere next week" passed about 1 week ago, any idea when this could be released?

@m4nug
Copy link

m4nug commented Dec 5, 2023

The "somewhere next week" passed about 1 week ago, any idea when this could be released?

taylorotwell commented last week
We will get to this after Pulse is released this week.

How can you write code if you can not even read?

@leknoppix
Copy link

The "somewhere next week" passed about 1 week ago, any idea when this could be released?

Certainly, the announcement of a new release compatible with vite 5 was announced a little too far in advance, but hey, I think that the developers don't just have that to do and deserve encouragement.
If you're in such a hurry, just modify the current code to make it evolve and submit a pull request to them.
This plugin is free, so, for my part, I don't really like this kind of remark.

Good luck to the developers.

@gabrielrbarbosa
Copy link

@leknoppix To be honest, I've opened the first issue #253 two months ago when Vite 5.0 was in beta and it was already marked for release this quarter, also @driesvints just closed many issues as completed when people started to use stable version...

So for now I'm just using workarounds and added --legacy-peer-deps to npm install and waiting :)

@driesvints
Copy link
Member Author

Hi all. We realise everyone wants Vite 5 support as soon as possible. We're doing the best we can with the resources we have and with other work also in mind. Keep an eye on our twitter to know when it's out.

@laravel laravel locked and limited conversation to collaborators Dec 5, 2023
@taylorotwell
Copy link
Member

Plan is to start on Vite 5 support next week. 🤘

@driesvints driesvints linked a pull request Dec 13, 2023 that will close this issue
@taylorotwell
Copy link
Member

Releasing today.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.