Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@Kazadhum this seems to be wrong. Should we not use additional_tf['child_link]? And this is quite a but. #1002

Closed
miguelriemoliveira opened this issue Jan 21, 2025 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@miguelriemoliveira
Copy link
Member

In file atom_core/src/atom_core/utilities.py

transform_key = generateKey(additional_tf["parent_link"], sensor["child_link"])

@miguelriemoliveira
Copy link
Member Author

Hey @Kazadhum ,

did you see this?

@miguelriemoliveira miguelriemoliveira added the bug Something isn't working label Jan 21, 2025
@Kazadhum
Copy link
Collaborator

Kazadhum commented Jan 21, 2025

Hi @miguelriemoliveira! Yes, this does seem very wrong...

This does impact my results with the Liang method for camera-IMU calibration, as it includes an additional transformation in its configuration. The good news is those calibrations can be re-done easily. I'll do that tomorrow.

@miguelriemoliveira
Copy link
Member Author

I fixed it but in a branch for #1001 . Will commit soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants