Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inclusion of rihibot in the ATOM repo #1007

Open
Kazadhum opened this issue Jan 23, 2025 · 2 comments
Open

Inclusion of rihibot in the ATOM repo #1007

Kazadhum opened this issue Jan 23, 2025 · 2 comments
Assignees
Labels
discussion Issue for discussing a topic

Comments

@Kazadhum
Copy link
Collaborator

Kazadhum commented Jan 23, 2025

Hello @miguelriemoliveira and @manuelgitgomes!

For my work on IMU data collection (see #1000), I created the rihibot simulated system, which is basically rihbot with an IMU on the end-effector. In the branch I'm using for development, I added this system directly to atom_examples.

Now, I'm basically ready to create a PR, but a question appeared in my mind. IMU calibration is not yet implemented, only data collection. With this in consideration, do you think I should include rihibot in atom_exmaples right away, with warnings in the documentation that IMU calibration is currently under development, or do you think its best if I move the system to a different repository before creating the PR?

I'm currently leaning towards the second option as it seems "cleaner" to me, but I'd like to ask your opinions.

@manuelgitgomes
Copy link
Collaborator

Hello!

I think the best solution is to create a branch to develop IMU calibration.
Then you can merge everything afterwards!

@Kazadhum
Copy link
Collaborator Author

Hi @manuelgitgomes! I thought about that when I created the branch I'm working on but, since IMU calibration means also adding the support for IMUs all across the ATOM pipeline, I thought it would result in a very large PR, which I'd like to avoid...

So I thought maybe it would be best if I split it in two, with the first one being just for implementing IMU data collection as well as continuous data collection... Perhaps I exclude rihibot from a first PR and only add it later on?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Issue for discussing a topic
Development

No branches or pull requests

2 participants