barrierDismissible not working properly

[Anilaydinaa]

I’ve encountered an issue with the barrierDismissible parameter in the UpgradeAlert widget not working as expected. The issue seems to stem from the onCanPop function in the upgrade_alert.dart file, which is always returning false, preventing the dialog from being dismissed.

Here’s the relevant part of the onCanPop function:

bool onCanPop() {
if (widget.upgrader.state.debugLogging) {
print('upgrader: onCanPop called');
}
if (widget.shouldPopScope != null) {
final should = widget.shouldPopScope!();
if (widget.upgrader.state.debugLogging) {
print('upgrader: shouldPopScope=$should');
}
return should;
}
return false;
}

Solution:

By making a small change to the onCanPop function, I was able to get barrierDismissible working properly. The key change is to return the widget.barrierDismissible value instead of always returning false:

bool onCanPop() {
if (widget.upgrader.state.debugLogging) {
print('upgrader: onCanPop called');
}
if (widget.shouldPopScope != null) {
final should = widget.shouldPopScope!();
if (widget.upgrader.state.debugLogging) {
print('upgrader: shouldPopScope=$should');
}
return should;
}
return widget.barrierDismissible;
}

With this modification, the barrierDismissible parameter now works as expected.

Is this a bug? Or did you do this intentionally? If so, why did you include the barrierDismissible parameter as an assignable value?

Good luck :)

[Anilaydinaa]

Solution to the problem:

UpgradeAlert(
shouldPopScope: () => true,
barrierDismissible: true,
dialogStyle: UpgradeDialogStyle.cupertino,
upgrader: Upgrader(
durationUntilAlertAgain: const Duration(minutes: 10),
),
)

Result: When the shouldPopScope and barrierDismissible parameters are used together, it works.

I will not delete the topic so that others who face the same issue can benefit from it.

If this is a bug, I hope it gets resolved soon.

P.S.: This works without making any changes to the main file of the package (upgrade_alert.dart).

[tekinonur]

+1