Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation Suggestions #1

Open
RichardKF opened this issue Aug 1, 2024 · 5 comments
Open

Documentation Suggestions #1

RichardKF opened this issue Aug 1, 2024 · 5 comments

Comments

@RichardKF
Copy link
Contributor

I think you have a terrific resource! I wish I had found it earlier; it would have saved me so much research time.

However, I found your documentation confusing at points (particularly in explaining how/why to use GoldenDict and Hunspell). I could offer some revisions that I think would clarify and perhaps streamline your docs and improve the user experience.

Before I send a pull request, though, I wanted to introduce myself and see if you would welcome feedback.

Best regards,
Richard Faulk

@nikita-moor
Copy link
Collaborator

nikita-moor commented Aug 3, 2024

@RichardKF
I will gladly accept your corrections because the English language is not my strong point.
You could either create a pull-request or send me the files.

P.S. Many dictionary shells were abandoned (e.g. Bluedict, GoldenDict Mobile), GoldenDict-NG emerged. I need to update the technical documentation as well. 🤕

@RichardKF
Copy link
Contributor Author

I guess I didn't notice your P.S. because I was about to mention that Bluedict seems to be abandoned. I'll be happy to check out the links and fix what I can. However, I'm locked into the Mac ecosystem, so I can't thoroughly investigate Android apps.

@nikita-moor
Copy link
Collaborator

I have merged your pull request. Thank you! Feel free to open a new one if you want to edit the website.

By the way, you have created goldendict-2.png and htmldict.png but do not use them in the text.

@RichardKF
Copy link
Contributor Author

Great! I didn't open another pull request until you merged the first because I didn't want to overstep. I will give some more suggestions now, though.

@nikita-moor
Copy link
Collaborator

Merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants