Skip to content
This repository has been archived by the owner on Oct 5, 2023. It is now read-only.

[BUG] After about 8-10 commands, game stops running. #138

Open
Vortexx1988 opened this issue Dec 12, 2019 · 12 comments
Open

[BUG] After about 8-10 commands, game stops running. #138

Vortexx1988 opened this issue Dec 12, 2019 · 12 comments
Labels
bug Something isn't working

Comments

@Vortexx1988
Copy link

Describe the bug
Every time I play the game, no matter what type of story I choose, after about 8-10 commands, the game stops responding.

To Reproduce
Play the game and type about 8-10 responses.

Expected behavior
Should be able to continue indefinitely, or at least until the end of the story.

Additional context
I've tried in both Google Chrome and Firefox, with the same results.

@Vortexx1988 Vortexx1988 added the bug Something isn't working label Dec 12, 2019
@kik4444
Copy link

kik4444 commented Dec 12, 2019

Are your responses long?

@robotimer
Copy link

I'm seeing this happen mostly when using dialogue. Something like typing: "Where are we?" instead of: ask where we are

I'm gonna try playing without ANY dialogue in quotes and see if that helps.

@kik4444
Copy link

kik4444 commented Dec 13, 2019

I'm seeing this happen mostly when using dialogue. Something like typing: "Where are we?" instead of: ask where we are

I'm gonna try playing without ANY dialogue in quotes and see if that helps.

Try not to use direct speech very often and if you have to, then save right before it

@AlSovPich
Copy link

AlSovPich commented Dec 14, 2019

I tried to play without direct speech, but after ten requests game just stopped. It just writes nothing. Maybe it is because of 'ask'. And if I start new game on same list (without reloading, just with 'restart'), I can play for ten phrases more.

@AlSovPich
Copy link

I tried again without 'ask'. All works normally.

@louisgv
Copy link
Contributor

louisgv commented Dec 15, 2019

Seems like this is resolved. Please close @AlSovPich

@Vortexx1988
Copy link
Author

I've tried playing without typing dialogue in quotation marks, I've tried without using 'ask', and the same thing seems to happen, sometimes now with a lengthy error message.

@AlSovPich
Copy link

Seems like this is resolved. Please close
Vortexx opened this issue, not me

@AlSovPich
Copy link

And it still crash after using direct speech

@Teravus
Copy link

Teravus commented Jan 14, 2020

The only way that I have found to resolve this is to reduce the size of the context being passed to the model. This has a side-effect of the model forgetting things. There's an internal history limit of 20 story items. To keep it relatively infinite, I'd suggest keeping the whole context at a maximum of 4000 characters. I used this to keep the model alive for many hours on Twitch.

@Sporking
Copy link

Sporking commented Mar 4, 2020

This could be a code correctness problem (buffer overflow or improper bounds checking), not an out-of-memory problem. See bug #251.

@Sporking
Copy link

Sporking commented Mar 4, 2020

If quotes or apostrophes seem to be related to the problem, please see my comments near the end of bug #55 .

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

7 participants