Skip to content
This repository has been archived by the owner on Sep 8, 2023. It is now read-only.

Magic.js will never succeed #13

Open
Draco18s opened this issue Oct 8, 2020 · 3 comments
Open

Magic.js will never succeed #13

Draco18s opened this issue Oct 8, 2020 · 3 comments

Comments

@Draco18s
Copy link

Draco18s commented Oct 8, 2020

https://github.com/AIDungeon/Scripting/blob/master/examples/magic.js#L23

Spell names are in ALL CAPS and compared to a ToLower() string.

@TheDudeFromCI
Copy link

It's intended to be replaced with actual spell names when implemented.

Noted on line 4: https://github.com/AIDungeon/Scripting/blob/182130f724123a47b9e28e3a8fa096188f7b5b0c/examples/magic.js#L4

@Draco18s
Copy link
Author

Draco18s commented Nov 5, 2020

Yes, but the fact that the temporary spell names are in ALL CAPS meant that several people on the discord server got confused when one guy was trying to set it up and it wasn't working. Because FIREBALL is not fireball: he didn't realize that he should put the spell names in all lower case because the template had them in all caps.

@TheDudeFromCI
Copy link

Ah, okay. So it's more of a documentation issue, then. That's fair.
Putting the spells in lowercase might reduce the confusion for new developers.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants