Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable download_url #87

Open
austinsalonen opened this issue Nov 12, 2019 · 2 comments
Open

Configurable download_url #87

austinsalonen opened this issue Nov 12, 2019 · 2 comments

Comments

@austinsalonen
Copy link

Would you be opposed to a pull request moving the downlad_url value to config.exs?

We use this behind a firewall and can only get database updates with tzdata releases.

@lau
Copy link
Owner

lau commented Nov 15, 2019

Hi. I'm not opposed to that :)

@wojtekmach
Copy link
Contributor

wojtekmach commented Nov 15, 2019

You mentioned you only get database updates with tzdata releases so you don't use the download functionality of tzdata? In that case, perhaps it's enough for you to disable the auto updater? https://github.com/lau/tzdata#automatic-data-updates

Or is there point that you do have an URL that you can hit to fetch the db, but it's not the default one?

How are you using other libraries that fetch data from somewhere (e.g. Hex). Do you use a proxy?

Just to be clear, I think customising the download url is a good idea because it gives extra flexibility (and makes it more testable) but I'm just trying to figure the exact use case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants