Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: explicit renaming list #238

Closed
therontarigo opened this issue Feb 24, 2023 · 1 comment
Closed

Feature request: explicit renaming list #238

therontarigo opened this issue Feb 24, 2023 · 1 comment

Comments

@therontarigo
Copy link
Contributor

It would be useful to have a command option for a list of things that should be renamed, in case they aren't. Since this would be useful primarily as a workaround for GLSL features that Shader_Minifier does not yet understand, the renamings should happen as for variables at global scope, with any instance of the identifier token being assumed a reference to this global item.

For example, from #237 :

buffer block_name{
  int member_name[];
};

shader_minifier --always-rename-list block_name,member_name would have these identifiers shortened. The required assumption that any instance of the identifier (as a C preprocessor would see it) is indeed a reference is to ensure that no further understanding by the tool of potentially unknown or unimplemented language features is needed.

@therontarigo
Copy link
Contributor Author

Closing in favor of #378.

@therontarigo therontarigo closed this as not planned Won't fix, can't repro, duplicate, stale May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant