From b45bba9030bbd392a0e21a50ead26f5dffc768ac Mon Sep 17 00:00:00 2001 From: Bibi Date: Sun, 26 Nov 2023 09:12:55 +0100 Subject: [PATCH] Updated documentation. Added Engine constants. Removed skipped tests. --- CHANGELOG.md | 27 +++++--- CONTRIBUTING.md | 59 ++++++++++-------- LICENSE | 38 ++++++------ README.md | 15 +++-- composer.lock | 12 ++-- resources/doc/cookbook.md | 6 ++ resources/doc/installation.md | 6 ++ resources/doc/usage.md | 6 ++ src/Highcharts/AbstractChart.php | 24 +++++--- src/Highcharts/ChartInterface.php | 9 +++ src/Highcharts/Highchart.php | 2 +- src/Highcharts/Highstock.php | 2 +- src/Twig/HighchartsExtension.php | 5 +- tests/AbstractChartTestCase.php | 3 + tests/Highcharts/ExportingTest.php | 13 ---- tests/Highcharts/PaneTest.php | 7 --- tests/Highstock/ChartTest.php | 88 --------------------------- tests/Highstock/RangeSelectorTest.php | 28 --------- 18 files changed, 136 insertions(+), 214 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 6f78b81..cef1ed3 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -3,6 +3,15 @@ ## [Unreleased] TBD +### [2.19.18] - 2023-11.26 +* Updated documentation +* Added Engine constants +* Removed skipped tests + +### [2.0.0] - 2022-03-21 +* Added PHP version 8.0. +* Update composer.json +* Update composer.json ### [1.7.0] - 2020-01-12 @@ -67,12 +76,12 @@ as possible. See http://framework.zend.com/security/advisory/ZF2014-01 * Initial release -[Unreleased]: https://github.com/marcaube/ObHighchartsBundle/compare/1.7...HEAD -[1.7.0]: https://github.com/marcaube/ObHighchartsBundle/compare/1.6...1.7 -[1.6.0]: https://github.com/marcaube/ObHighchartsBundle/compare/1.5...1.6 -[1.5.0]: https://github.com/marcaube/ObHighchartsBundle/compare/1.4...1.5 -[1.4.0]: https://github.com/marcaube/ObHighchartsBundle/compare/1.3...1.4 -[1.3.0]: https://github.com/marcaube/ObHighchartsBundle/compare/1.2...1.3 -[1.2.0]: https://github.com/marcaube/ObHighchartsBundle/compare/1.1...1.2 -[1.1.0]: https://github.com/marcaube/ObHighchartsBundle/compare/1.0.1...1.1 -[1.0.1]: https://github.com/marcaube/ObHighchartsBundle/compare/1.0...1.0.1 +[Unreleased]: https://github.com/laurentmuller/HighchartsBundle/compare/1.7...HEAD +[1.7.0]: https://github.com/laurentmuller/HighchartsBundle/compare/1.6...1.7 +[1.6.0]: https://github.com/laurentmuller/HighchartsBundle/compare/1.5...1.6 +[1.5.0]: https://github.com/laurentmuller/HighchartsBundle/compare/1.4...1.5 +[1.4.0]: https://github.com/laurentmuller/HighchartsBundle/compare/1.3...1.4 +[1.3.0]: https://github.com/laurentmuller/HighchartsBundle/1.2...1.3 +[1.2.0]: https://github.com/laurentmuller/HighchartsBundle/1.1...1.2 +[1.1.0]: https://github.com/laurentmuller/HighchartsBundle/1.0.1...1.1 +[1.0.1]: https://github.com/laurentmuller/HighchartsBundle/1.0...1.0.1 diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 81fcb74..157966b 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -1,26 +1,33 @@ -# Contributing - -First of all, **thank you** for contributing, **you are awesome**! - -Here are a few rules to follow in order to ease code reviews, and discussions before maintainers accept and merge your work. - -You MUST follow the [PSR-4](http://www.php-fig.org/psr/psr-4) and [PSR-2](http://www.php-fig.org/psr/2/). If you don't know -about any of them, you should really read the recommendations. Can't wait? Use the [PHP-CS-Fixer tool](http://cs.sensiolabs.org/). - -You MUST run the test suite. - -You MUST write (or update) unit tests. - -You SHOULD write documentation. - -Please, write [commit messages that make sense](http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html), -and [rebase your branch](http://git-scm.com/book/en/Git-Branching-Rebasing) before submitting your Pull Request. - -One may ask you to [squash your commits](http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html) -too. This is used to "clean" your Pull Request before merging it (we don't want commits such as `fix tests`, `fix 2`, -`fix 3`, etc.). - -Also, while creating your Pull Request on GitHub, you MUST write a description which gives the context and/or explains -why you are creating it. - -Thank you! \ No newline at end of file +# Contributing + +First of all, **thank you** for contributing, **you are awesome**! + +Here are a few rules to follow in order to ease code reviews, and discussions before maintainers accept and merge your work. + +You MUST follow the [PSR-4](http://www.php-fig.org/psr/psr-4) and [PSR-2](http://www.php-fig.org/psr/2/). If you don't know +about any of them, you should really read the recommendations. Can't wait? Use the [PHP-CS-Fixer tool](http://cs.sensiolabs.org/). + +You MUST run the test suite. + +You MUST write (or update) unit tests. + +You SHOULD write documentation. + +Please, write [commit messages that make sense](http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html), +and [rebase your branch](http://git-scm.com/book/en/Git-Branching-Rebasing) before submitting your Pull Request. + +One may ask you to [squash your commits](http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html) +too. This is used to "clean" your Pull Request before merging it (we don't want commits such as `fix tests`, `fix 2`, +`fix 3`, etc.). + +Also, while creating your Pull Request on GitHub, you MUST write a description which gives the context and/or explains +why you are creating it. + +Thank you! + +## See also: + +- [Installation](resources/doc/installation.md) +- [Usage](resources/doc/usage.md) +- [Cookbook](resources/doc/cookbook.md) +- [Home Page](README.md) diff --git a/LICENSE b/LICENSE index e404d9b..49937ce 100644 --- a/LICENSE +++ b/LICENSE @@ -1,19 +1,19 @@ -Copyright (c) 2015 Marc Aube - -Permission is hereby granted, free of charge, to any person obtaining a copy -of this software and associated documentation files (the "Software"), to deal -in the Software without restriction, including without limitation the rights -to use, copy, modify, merge, publish, distribute, sublicense, and/or sell -copies of the Software, and to permit persons to whom the Software is furnished -to do so, subject to the following conditions: - -The above copyright notice and this permission notice shall be included in all -copies or substantial portions of the Software. - -THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR -IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, -FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE -AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER -LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, -OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN -THE SOFTWARE. +Copyright (c) 2023 Laurent Muller + +Permission is hereby granted, free of charge, to any person obtaining a copy +of this software and associated documentation files (the "Software"), to deal +in the Software without restriction, including without limitation the rights +to use, copy, modify, merge, publish, distribute, sublicense, and/or sell +copies of the Software, and to permit persons to whom the Software is furnished +to do so, subject to the following conditions: + +The above copyright notice and this permission notice shall be included in all +copies or substantial portions of the Software. + +THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR +IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, +FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE +AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER +LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, +OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN +THE SOFTWARE. diff --git a/README.md b/README.md index 662ff39..f9f35d6 100644 --- a/README.md +++ b/README.md @@ -1,16 +1,19 @@ # HighchartsBundle +This is fork of the [ObHighchartsBundle](https://github.com/marcaube/ObHighchartsBundle) with support for PHP 8.0. + `HighchartsBundle` eases the use of highcharts to display rich graphs and charts in your Symfony application by providing Twig extensions and PHP objects to do the heavy lifting. The bundle uses the excellent JS library [Highcharts](https://www.highcharts.com). + DRY out your chart code by writing it all in PHP! -[![Php-cs-fixer](https://github.com/laurentmuller/ObHighchartsBundle/actions/workflows/php-cs-fixer.yaml/badge.svg)](https://github.com/laurentmuller/ObHighchartsBundle/actions/workflows/php-cs-fixer.yaml) -[![PHP-Stan](https://github.com/laurentmuller/ObHighchartsBundle/actions/workflows/php-stan.yaml/badge.svg)](https://github.com/laurentmuller/ObHighchartsBundle/actions/workflows/php-stan.yaml) -[![Rector](https://github.com/laurentmuller/ObHighchartsBundle/actions/workflows/rector.yaml/badge.svg)](https://github.com/laurentmuller/ObHighchartsBundle/actions/workflows/rector.yaml/badge.svg) -[![PHPUnit](https://github.com/laurentmuller/ObHighchartsBundle/actions/workflows/php-unit.yaml/badge.svg)](https://github.com/laurentmuller/ObHighchartsBundle/actions/workflows/php-unit.yaml) -[![Psalm Static analysis](https://github.com/laurentmuller/ObHighchartsBundle/actions/workflows/psalm.yaml/badge.svg)](https://github.com/laurentmuller/ObHighchartsBundle/actions/workflows/psalm.yaml) +[![Php-cs-fixer](https://github.com/laurentmuller/HighchartsBundle/actions/workflows/php-cs-fixer.yaml/badge.svg)](https://github.com/laurentmuller/HighchartsBundle/actions/workflows/php-cs-fixer.yaml) +[![PHP-Stan](https://github.com/laurentmuller/HighchartsBundle/actions/workflows/php-stan.yaml/badge.svg)](https://github.com/laurentmuller/HighchartsBundle/actions/workflows/php-stan.yaml) +[![Rector](https://github.com/laurentmuller/HighchartsBundle/actions/workflows/rector.yaml/badge.svg)](https://github.com/laurentmuller/HighchartsBundle/actions/workflows/rector.yaml) +[![PHPUnit](https://github.com/laurentmuller/HighchartsBundle/actions/workflows/php-unit.yaml/badge.svg)](https://github.com/laurentmuller/HighchartsBundle/actions/workflows/php-unit.yaml) +[![Psalm Static analysis](https://github.com/laurentmuller/HighchartsBundle/actions/workflows/psalm.yaml/badge.svg)](https://github.com/laurentmuller/HighchartsBundle/actions/workflows/psalm.yaml) [![StyleCI](https://github.styleci.io/repos/472412531/shield?branch=master)](https://github.styleci.io/repos/472412531?branch=master) ## Documentation @@ -26,7 +29,7 @@ See [CONTRIBUTING](CONTRIBUTING.md) file. ## License -ObHighchartsBundle is released under the MIT License. See the bundled [LICENSE](LICENSE) file for details. +HighchartsBundle is released under the MIT License. See the bundled [LICENSE](LICENSE) file for details. Please note that the Highcharts JS library is **not** free for commercial use, see their [FAQ](http://shop.highsoft.com/faq) for more details on what constitutes a non-commercial project or their diff --git a/composer.lock b/composer.lock index 64c0e7e..769f6fb 100644 --- a/composer.lock +++ b/composer.lock @@ -2272,16 +2272,16 @@ }, { "name": "friendsofphp/php-cs-fixer", - "version": "v3.39.0", + "version": "v3.39.1", "source": { "type": "git", "url": "https://github.com/PHP-CS-Fixer/PHP-CS-Fixer.git", - "reference": "04bf7b28fc847185b247d112cab617da941e3cca" + "reference": "857046d26b0d92dc13c4be769309026b100b517e" }, "dist": { "type": "zip", - "url": "https://api.github.com/repos/PHP-CS-Fixer/PHP-CS-Fixer/zipball/04bf7b28fc847185b247d112cab617da941e3cca", - "reference": "04bf7b28fc847185b247d112cab617da941e3cca", + "url": "https://api.github.com/repos/PHP-CS-Fixer/PHP-CS-Fixer/zipball/857046d26b0d92dc13c4be769309026b100b517e", + "reference": "857046d26b0d92dc13c4be769309026b100b517e", "shasum": "" }, "require": { @@ -2353,7 +2353,7 @@ ], "support": { "issues": "https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/issues", - "source": "https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/tree/v3.39.0" + "source": "https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/tree/v3.39.1" }, "funding": [ { @@ -2361,7 +2361,7 @@ "type": "github" } ], - "time": "2023-11-22T11:20:09+00:00" + "time": "2023-11-24T22:59:03+00:00" }, { "name": "myclabs/deep-copy", diff --git a/resources/doc/cookbook.md b/resources/doc/cookbook.md index 04799c4..025698a 100644 --- a/resources/doc/cookbook.md +++ b/resources/doc/cookbook.md @@ -165,3 +165,9 @@ $formatter = new Expr('function () { $chart->tooltip->formatter($formatter); $chart->series($series); ``` + +## See also: + +- [Installation](installation.md) +- [Usage](usage.md) +- [Home Page](../../README.md) diff --git a/resources/doc/installation.md b/resources/doc/installation.md index 01fd5fb..3b07016 100644 --- a/resources/doc/installation.md +++ b/resources/doc/installation.md @@ -15,3 +15,9 @@ ... ] ``` + +## See also: + +- [Usage](usage.md) +- [Cookbook](cookbook.md) +- [Home Page](../../README.md) diff --git a/resources/doc/usage.md b/resources/doc/usage.md index ba9a53d..78f0858 100644 --- a/resources/doc/usage.md +++ b/resources/doc/usage.md @@ -92,3 +92,9 @@ $chart = new Highchart(); $chart->tooltip->formatter($func); // ... ``` + +## See also: + +- [Installation](installation.md) +- [Cookbook](cookbook.md) +- [Home Page](../../README.md) diff --git a/src/Highcharts/AbstractChart.php b/src/Highcharts/AbstractChart.php index 43f235d..d6e35fe 100644 --- a/src/Highcharts/AbstractChart.php +++ b/src/Highcharts/AbstractChart.php @@ -21,10 +21,13 @@ abstract class AbstractChart implements ChartInterface { // the script end line - private const END_LINE = ",\n"; + protected const END_LINE = ",\n"; + + // the script new line + protected const NEW_LINE = "\n"; // the space prefix - private const SPACE = ' '; + protected const SPACE = ' '; // The Zend json encode options. private const ZEND_ENCODE_OPTIONS = ['enableJsonExprFinder' => true]; @@ -75,7 +78,10 @@ public function __call(string $name, mixed $value): static return $this; } - public function render(string $engine = 'jquery'): string + /** + * @psalm-param ChartInterface::ENGINE_* $engine + */ + public function render(string $engine = self::ENGINE_JQUERY): string { $chartJS = ''; $this->renderChartStart($chartJS, $engine); @@ -188,9 +194,9 @@ protected function renderChartCommon(string &$chartJS): void protected function renderChartEnd(string &$chartJS, string $engine): void { // trim last trailing comma and close parenthesis - $chartJS = \rtrim($chartJS, self::END_LINE) . "\n });\n"; + $chartJS = \rtrim($chartJS, self::END_LINE) . "\n });" . self::NEW_LINE; if ('' !== $engine) { - $chartJS .= "});\n"; + $chartJS .= '});' . self::NEW_LINE; } } @@ -217,8 +223,8 @@ protected function renderCredits(): string protected function renderEngine(string $engine): string { return match ($engine) { - 'mootools' => 'window.addEvent(\'domready\', function () {', - 'jquery' => '$(function () {', + self::ENGINE_MOOTOOLS => 'window.addEvent(\'domready\', function () {', + self::ENGINE_JQUERY => '$(function () {', default => '', }; } @@ -249,11 +255,11 @@ protected function renderOptions(): string return ''; } - $result = "\n Highcharts.setOptions({\n"; + $result = self::NEW_LINE . self::SPACE . ' Highcharts.setOptions({' . self::NEW_LINE; $result .= $this->renderGlobal(); $result .= $this->renderLang(); - return $result . " });\n"; + return $result . self::SPACE . '});' . self::NEW_LINE; } protected function renderPlotOptions(): string diff --git a/src/Highcharts/ChartInterface.php b/src/Highcharts/ChartInterface.php index 6d6aa23..80f732f 100644 --- a/src/Highcharts/ChartInterface.php +++ b/src/Highcharts/ChartInterface.php @@ -17,5 +17,14 @@ */ interface ChartInterface { + public const ENGINE_JQUERY = 'jquery'; + + public const ENGINE_MOOTOOLS = 'mootools'; + + public const ENGINE_NONE = ''; + + /** + * @psalm-param self::ENGINE_* $engine + */ public function render(string $engine): string; } diff --git a/src/Highcharts/Highchart.php b/src/Highcharts/Highchart.php index 2d81fb8..823cde1 100644 --- a/src/Highcharts/Highchart.php +++ b/src/Highcharts/Highchart.php @@ -45,7 +45,7 @@ protected function renderChartOptions(string &$chartJS): void protected function renderChartStart(string &$chartJS, string $engine): void { parent::renderChartStart($chartJS, $engine); - $chartJS .= " const {$this->getRenderTo()} = new Highcharts.Chart({\n"; + $chartJS .= self::SPACE . "const {$this->getRenderTo()} = new Highcharts.Chart({" . self::NEW_LINE; } private function renderColorAxis(): string diff --git a/src/Highcharts/Highstock.php b/src/Highcharts/Highstock.php index 45088cf..dd39804 100644 --- a/src/Highcharts/Highstock.php +++ b/src/Highcharts/Highstock.php @@ -36,7 +36,7 @@ protected function renderChartOptions(string &$chartJS): void protected function renderChartStart(string &$chartJS, string $engine): void { parent::renderChartStart($chartJS, $engine); - $chartJS .= " const {$this->getRenderTo()} = new Highcharts.StockChart({\n"; + $chartJS .= self::SPACE . "const {$this->getRenderTo()} = new Highcharts.StockChart({" . self::END_LINE; } protected function renderRangeSelector(): string diff --git a/src/Twig/HighchartsExtension.php b/src/Twig/HighchartsExtension.php index dcc3caa..1b0a3f2 100644 --- a/src/Twig/HighchartsExtension.php +++ b/src/Twig/HighchartsExtension.php @@ -18,7 +18,10 @@ class HighchartsExtension extends AbstractExtension { - public function chart(ChartInterface $chart, string $engine = 'jquery'): string + /** + * @psalm-param ChartInterface::ENGINE_* $engine + */ + public function chart(ChartInterface $chart, string $engine = ChartInterface::ENGINE_JQUERY): string { return $chart->render($engine); } diff --git a/tests/AbstractChartTestCase.php b/tests/AbstractChartTestCase.php index 856761d..5ea2fca 100644 --- a/tests/AbstractChartTestCase.php +++ b/tests/AbstractChartTestCase.php @@ -17,6 +17,9 @@ class AbstractChartTestCase extends TestCase { + /** + * @psalm-param ChartInterface::ENGINE_* $engine + */ protected function assertChartMatchesRegularExpression(ChartInterface $chart, string $regex, string $engine = 'jquery'): void { $result = $chart->render($engine); diff --git a/tests/Highcharts/ExportingTest.php b/tests/Highcharts/ExportingTest.php index 70e283a..70b549e 100644 --- a/tests/Highcharts/ExportingTest.php +++ b/tests/Highcharts/ExportingTest.php @@ -66,19 +66,6 @@ public function testButtons(): void // width option (integer - width in px) // x option (integer - horizontal offset in px) // y option (integer - vertical offset in px) - $this->markTestIncomplete( - 'This test has not been implemented yet.' - ); - } - - /** - * chartOptions option. - */ - public function testChartOptions(): void - { - $this->markTestIncomplete( - 'This test has not been implemented yet.' - ); } /** diff --git a/tests/Highcharts/PaneTest.php b/tests/Highcharts/PaneTest.php index ef7fb30..e7ce2c7 100644 --- a/tests/Highcharts/PaneTest.php +++ b/tests/Highcharts/PaneTest.php @@ -20,13 +20,6 @@ */ class PaneTest extends AbstractChartTestCase { - public function testBackground(): void - { - $this->markTestIncomplete( - 'This test has not been implemented yet.' - ); - } - public function testCenter(): void { $chart = new Highchart(); diff --git a/tests/Highstock/ChartTest.php b/tests/Highstock/ChartTest.php index f9a8342..2a947c7 100644 --- a/tests/Highstock/ChartTest.php +++ b/tests/Highstock/ChartTest.php @@ -102,12 +102,6 @@ public function testClassName(): void $this->assertChartMatchesRegularExpression($this->chart, $regex); } - public function testEvents(): void - { - $this->assertNotNull($this->chart); - $this->markTestIncomplete(); - } - public function testHeight(): void { $this->assertNotNull($this->chart); @@ -132,12 +126,6 @@ public function testIgnoreHiddenSeries(): void $this->assertChartMatchesRegularExpression($this->chart, $regex); } - public function testMargin(): void - { - $this->assertNotNull($this->chart); - $this->markTestIncomplete(); - } - public function testMarginBottom(): void { $this->assertNotNull($this->chart); @@ -192,66 +180,6 @@ public function testPanning(): void $this->assertChartMatchesRegularExpression($this->chart, $regex); } - public function testPlotBackgroundColor(): void - { - $this->assertNotNull($this->chart); - $this->markTestIncomplete(); - } - - public function testPlotBackgroundImage(): void - { - $this->assertNotNull($this->chart); - $this->markTestIncomplete(); - } - - public function testPlotBorderColor(): void - { - $this->assertNotNull($this->chart); - $this->markTestIncomplete(); - } - - public function testPlotBorderWidth(): void - { - $this->assertNotNull($this->chart); - $this->markTestIncomplete(); - } - - public function testPlotShadow(): void - { - $this->assertNotNull($this->chart); - $this->markTestIncomplete(); - } - - public function testReflow(): void - { - $this->assertNotNull($this->chart); - $this->markTestIncomplete(); - } - - public function testRenderTo(): void - { - $this->assertNotNull($this->chart); - $this->markTestIncomplete(); - } - - public function testSelectionMarkerFIll(): void - { - $this->assertNotNull($this->chart); - $this->markTestIncomplete(); - } - - public function testShadow(): void - { - $this->assertNotNull($this->chart); - $this->markTestIncomplete(); - } - - public function testSpacing(): void - { - $this->assertNotNull($this->chart); - $this->markTestIncomplete(); - } - public function testSpacingBottom(): void { $this->assertNotNull($this->chart); @@ -292,17 +220,6 @@ public function testSpacingTop(): void $this->assertChartMatchesRegularExpression($this->chart, $regex); } - public function testStyle(): void - { - $this->assertNotNull($this->chart); - $this->markTestIncomplete(); - } - - public function testType(): void - { - $this->markTestIncomplete(); - } - public function testWidth(): void { $this->assertNotNull($this->chart); @@ -312,9 +229,4 @@ public function testWidth(): void $regex = '/"width":"800px"/'; $this->assertChartMatchesRegularExpression($this->chart, $regex); } - - public function testZoomType(): void - { - $this->markTestIncomplete(); - } } diff --git a/tests/Highstock/RangeSelectorTest.php b/tests/Highstock/RangeSelectorTest.php index bd5de06..796fcbf 100644 --- a/tests/Highstock/RangeSelectorTest.php +++ b/tests/Highstock/RangeSelectorTest.php @@ -53,13 +53,6 @@ public function testButtonSpacing(): void $this->assertChartMatchesRegularExpression($this->chart, $regex); } - public function testButtonTheme(): void - { - $this->assertNotNull($this->chart); - $this->assertNotNull($this->range); - $this->markTestIncomplete(); - } - public function testEnabled(): void { $this->assertNotNull($this->chart); @@ -119,13 +112,6 @@ public function testInputDateFormat(): void $this->assertChartMatchesRegularExpression($this->chart, $regex); } - public function testInputDateParser(): void - { - $this->assertNotNull($this->chart); - $this->assertNotNull($this->range); - $this->markTestIncomplete(); - } - public function testInputEditDateFormat(): void { $format = '%b %e, %Y'; @@ -165,20 +151,6 @@ public function testInputPosition(): void $this->assertChartMatchesRegularExpression($this->chart, $regex); } - public function testInputStyle(): void - { - $this->assertNotNull($this->chart); - $this->assertNotNull($this->range); - $this->markTestIncomplete(); - } - - public function testLabelStyle(): void - { - $this->assertNotNull($this->chart); - $this->assertNotNull($this->range); - $this->markTestIncomplete(); - } - public function testSelected(): void { $index = 3;