Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow usage of non-allocating frame buffers #1095

Merged
merged 2 commits into from
Aug 20, 2024
Merged

Conversation

devoxin
Copy link
Member

@devoxin devoxin commented Aug 20, 2024

This PR introduces a config option for toggling the use of non-allocating frame buffers.

In a high traffic environment, this can reduce pressure on the garbage collector by allowing each player to use a frame buffer specifically designed to reduce allocations by directly passing audio between byte buffers created at initialisation rather than when copying data outside of the player's control (i.e. user code). This should also have a positive effect by reducing CPU usage, thus increasing server performance.

@devoxin devoxin changed the base branch from master to dev August 20, 2024 18:44
@devoxin devoxin requested a review from topi314 August 20, 2024 18:53
@topi314 topi314 merged commit 21bdd69 into dev Aug 20, 2024
1 of 2 checks passed
@topi314 topi314 deleted the feat/non-alloc-framebuffer branch August 20, 2024 20:50
@topi314 topi314 mentioned this pull request Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants