Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider wrapping library's code in a namespace #14

Open
zenden2k opened this issue Jun 18, 2015 · 3 comments
Open

Consider wrapping library's code in a namespace #14

zenden2k opened this issue Jun 18, 2015 · 3 comments

Comments

@zenden2k
Copy link
Contributor

It is a common practice for c++ libraries to avoid naming collisions.
For example, CDocument is a very common class name in C++ projects.
It could be namespace GumboQuery { or something like this.

@zenden2k zenden2k changed the title Consider wrapping your code in a namespace Consider wrapping library's code in a namespace Jun 18, 2015
@micfan
Copy link

micfan commented Jul 19, 2015

Right, but that name is too long...

And, I prefer a Boost style namespace use lower case letters, such as gQeury::doc

@TechnikEmpire
Copy link

There's no need to shorten the namespace for user preference. That's why we have features like namespace short = some::long::possibly::nested::namespace; or namespace mypref = GumboQuery. :)

Namepace ought to be unique and spell out explicitly at full length what the unique namespace is.

@TechnikEmpire
Copy link

Also imo this is something so simple, somebody could do this in 2 minutes and create a pull request instead of throwing the burden on the repo maintainer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants