You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In readme.md, "brew install gumbo-query" does not work so I am using brew tap instead. There are many problem in the gumbo-query.rb as indicated here Homebrew/legacy-homebrew#50276
Maybe the repo should point to this repo instead of Falven's.
No need to have sha256. I do not know much about homebrew formula but the sha245 seems to be for installing form an archive.
"install" does not work at all. "system" should be inside "cd".
The test does not work because the build folder does not exist when using "brew test". I do not know the way to properly write such a test in the formula so I removed the test in the formula below. Examples I found always create an adhoc file for testing, e.g. https://github.com/Homebrew/homebrew/blob/master/Library/Formula/tinyxml2.rb
The version of gumbo-query is always "query". I guess that because there is no versions and the last word accidentally matches brew formula naming convention. It is not a big problem comparing with problem 3.
class GumboQuery < Formula
homepage "https://github.com/lazytiger/gumbo-query"
url "https://github.com/lazytiger/gumbo-query", :using => :git
depends_on "cmake" => :build
def install
cd "build" do
system "cmake", "..", "-DCMAKE_INSTALL_PREFIX=#{prefix}"
system "make"
system "make", "install"
end
end
end
The text was updated successfully, but these errors were encountered:
In readme.md, "brew install gumbo-query" does not work so I am using brew tap instead. There are many problem in the gumbo-query.rb as indicated here Homebrew/legacy-homebrew#50276
The text was updated successfully, but these errors were encountered: