From 4ddea6ca6e80452b031a6202251fdd16af2cd4b0 Mon Sep 17 00:00:00 2001
From: Gagandeep Singh <gdp.1807@gmail.com>
Date: Fri, 5 Jan 2024 22:21:17 +0530
Subject: [PATCH 1/3] Following changes have been made,

DEV: Added support for && and ! operators

DEV: Process CXXBoolLiteralExpr
---
 src/lc/clang_ast_to_asr.h | 47 +++++++++++++++++++++++++++++++++++++++
 1 file changed, 47 insertions(+)

diff --git a/src/lc/clang_ast_to_asr.h b/src/lc/clang_ast_to_asr.h
index 2f30b28..c25c1a4 100644
--- a/src/lc/clang_ast_to_asr.h
+++ b/src/lc/clang_ast_to_asr.h
@@ -1345,6 +1345,21 @@ class ClangASTtoASRVisitor: public clang::RecursiveASTVisitor<ClangASTtoASRVisit
         }
     }
 
+    void CreateLogicalOp(ASR::expr_t* lhs, ASR::expr_t* rhs,
+        ASR::logicalbinopType binop_type, const Location& loc) {
+        cast_helper(lhs, rhs, false);
+        ASRUtils::make_ArrayBroadcast_t_util(al, loc, lhs, rhs);
+        if( ASRUtils::is_integer(*ASRUtils::expr_type(lhs)) &&
+            ASRUtils::is_integer(*ASRUtils::expr_type(rhs)) ) {
+            tmp = ASR::make_LogicalBinOp_t(al, loc, lhs,
+                binop_type, rhs, ASRUtils::expr_type(lhs), nullptr);
+        } else {
+            throw std::runtime_error("Only integer types are supported so "
+                "far for logical binary operator, found: " + ASRUtils::type_to_str(ASRUtils::expr_type(lhs))
+                + " and " + ASRUtils::type_to_str(ASRUtils::expr_type(rhs)));
+        }
+    }
+
     void CreateBinOp(ASR::expr_t* lhs, ASR::expr_t* rhs,
         ASR::binopType binop_type, const Location& loc) {
         cast_helper(lhs, rhs, false);
@@ -1368,6 +1383,17 @@ class ClangASTtoASRVisitor: public clang::RecursiveASTVisitor<ClangASTtoASRVisit
         }
     }
 
+    void CreateLogicalNot(ASR::expr_t* op, const Location& loc) {
+        if( ASRUtils::is_logical(*ASRUtils::expr_type(op)) ) {
+            tmp = ASR::make_LogicalNot_t(al, loc, op,
+                ASRUtils::expr_type(op), nullptr);
+        } else {
+            throw std::runtime_error("Only logical types are supported so "
+                "far for logical not operator, found: " +
+                ASRUtils::type_to_str(ASRUtils::expr_type(op)));
+        }
+    }
+
     void CreateUnaryMinus(ASR::expr_t* op, const Location& loc) {
         if( ASRUtils::is_integer(*ASRUtils::expr_type(op)) ) {
             tmp = ASR::make_IntegerUnaryMinus_t(al, loc, op,
@@ -1393,8 +1419,10 @@ class ClangASTtoASRVisitor: public clang::RecursiveASTVisitor<ClangASTtoASRVisit
             is_stmt_created = true;
         } else {
             bool is_binop = false, is_cmpop = false;
+            bool is_logicalbinop = false;
             ASR::binopType binop_type;
             ASR::cmpopType cmpop_type;
+            ASR::logicalbinopType logicalbinop_type;
             switch (op) {
                 case clang::BO_Add: {
                     binop_type = ASR::binopType::Add;
@@ -1446,6 +1474,11 @@ class ClangASTtoASRVisitor: public clang::RecursiveASTVisitor<ClangASTtoASRVisit
                     is_cmpop = true;
                     break;
                 }
+                case clang::BO_LAnd: {
+                    logicalbinop_type = ASR::logicalbinopType::And;
+                    is_logicalbinop = true;
+                    break;
+                }
                 default: {
                     throw std::runtime_error("BinaryOperator not supported " + std::to_string(op));
                     break;
@@ -1455,6 +1488,8 @@ class ClangASTtoASRVisitor: public clang::RecursiveASTVisitor<ClangASTtoASRVisit
                 CreateBinOp(x_lhs, x_rhs, binop_type, Lloc(x));
             } else if( is_cmpop ) {
                 CreateCompareOp(x_lhs, x_rhs, cmpop_type, Lloc(x));
+            } else if( is_logicalbinop ) {
+                CreateLogicalOp(x_lhs, x_rhs, logicalbinop_type, Lloc(x));
             } else {
                 throw std::runtime_error("Only binary operators supported so far");
             }
@@ -1604,6 +1639,14 @@ class ClangASTtoASRVisitor: public clang::RecursiveASTVisitor<ClangASTtoASRVisit
         return true;
     }
 
+    bool TraverseCXXBoolLiteralExpr(clang::CXXBoolLiteralExpr* x) {
+        bool b = x->getValue();
+        tmp = ASR::make_LogicalConstant_t(al, Lloc(x), b,
+            ASRUtils::TYPE(ASR::make_Logical_t(al, Lloc(x), 4)));
+        is_stmt_created = false;
+        return true;
+    }
+
     bool TraverseFloatingLiteral(clang::FloatingLiteral* x) {
         double d = x->getValue().convertToDouble();
         tmp = ASR::make_RealConstant_t(al, Lloc(x), d,
@@ -1715,6 +1758,10 @@ class ClangASTtoASRVisitor: public clang::RecursiveASTVisitor<ClangASTtoASRVisit
                 CreateUnaryMinus(var, Lloc(x));
                 break;
             }
+            case clang::UnaryOperatorKind::UO_LNot: {
+                CreateLogicalNot(var, Lloc(x));
+                break;
+            }
             default: {
                 throw std::runtime_error("Only postfix increment and minus are supported so far.");
             }

From 8fd029b95282a27ecff17d699a749d2e8491047b Mon Sep 17 00:00:00 2001
From: Gagandeep Singh <gdp.1807@gmail.com>
Date: Fri, 5 Jan 2024 22:23:59 +0530
Subject: [PATCH 2/3] TEST: Ported integration_tests/arrays_inputs_15.f90 from
 LFortran

---
 integration_tests/array_20.cpp | 47 ++++++++++++++++++++++++++++++++++
 1 file changed, 47 insertions(+)
 create mode 100644 integration_tests/array_20.cpp

diff --git a/integration_tests/array_20.cpp b/integration_tests/array_20.cpp
new file mode 100644
index 0000000..0f43184
--- /dev/null
+++ b/integration_tests/array_20.cpp
@@ -0,0 +1,47 @@
+#include <iostream>
+#include <cmath>
+#include <xtensor/xtensor.hpp>
+#include <xtensor/xfixed.hpp>
+#include "xtensor/xio.hpp"
+
+void copy_from_to(const xt::xtensor_fixed<int, xt::xshape<10>>& xa,
+    xt::xtensor_fixed<int, xt::xshape<10>>&xb) {
+    int i;
+    for( i = 0; i < xa.size(); i++ ) {
+        xb(i) = xa(i);
+    }
+}
+
+bool verify(const xt::xtensor_fixed<int, xt::xshape<10>>& a,
+   const xt::xtensor_fixed<int, xt::xshape<10>>& b) {
+    int i;
+    bool r = true;
+    for( i = 0; i < a.size(); i++ ) {
+        r = r && (a(i) == b(i));
+    }
+
+    return r;
+}
+
+int main() {
+
+    xt::xtensor_fixed<int, xt::xshape<10>> x, y;
+    int i;
+    bool r;
+
+    for( i = 0; i < x.size(); i++ ) {
+        x(i) = i;
+    }
+
+    copy_from_to(x, y);
+    std::cout<< x << std::endl;
+    std::cout << y << std::endl;
+    r = verify(x, y);
+    std::cout << r << std::endl;
+    if (!r) {
+        exit(2);
+    }
+
+    return 0;
+
+}

From d89e76fdf76d5768d1ccb2c2cb0b4ffdaab88899 Mon Sep 17 00:00:00 2001
From: Gagandeep Singh <gdp.1807@gmail.com>
Date: Fri, 5 Jan 2024 22:24:15 +0530
Subject: [PATCH 3/3] TEST: Registered array_20.cpp

---
 integration_tests/CMakeLists.txt | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/integration_tests/CMakeLists.txt b/integration_tests/CMakeLists.txt
index c80ca84..21c16ff 100644
--- a/integration_tests/CMakeLists.txt
+++ b/integration_tests/CMakeLists.txt
@@ -216,3 +216,5 @@ RUN(NAME array_18.cpp LABELS gcc llvm NOFAST
     EXTRA_ARGS --extra-arg=-I${CONDA_PREFIX}/include)
 RUN(NAME array_19.cpp LABELS gcc llvm NOFAST
     EXTRA_ARGS --extra-arg=-I${CONDA_PREFIX}/include)
+RUN(NAME array_20.cpp LABELS gcc llvm NOFAST
+    EXTRA_ARGS --extra-arg=-I${CONDA_PREFIX}/include)