Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

faros-ng/deploy-pack : doublon de tâches Ansible le-phare/ansible-deploy ? #8

Open
lucasmirloup opened this issue Jun 15, 2023 · 3 comments

Comments

@lucasmirloup
Copy link
Member

Les tasks de faros-ng/deploy-pack/1.5/ansible/deploy.yml ont l'air redondantes avec la tâche publish_assets de le-phare/ansible-deploy (activée par défaut) :
https://github.com/le-phare/ansible-deploy/blob/c7f80bcf2c5d8814db9a9b498ca1d3df175e78be/config/steps/publish_assets.yml

@lucasmirloup
Copy link
Member Author

Cc @thislg @pchabbert

@aegypius
Copy link
Contributor

@lucasmirloup C'est effectivement le cas, il faudrait probablement ajouter la version de la recette flex dans ansible-deploy.

La partie importante c'est ça :

- name: Check directory
delegate_to: localhost
stat:
path: ../public/build/
register: build_dir
- name: Upload assets
when: build_dir.stat.exists and build_dir.stat.isdir

En son absence, si le developpeur oublie de builder les assets, les options ci-dessous supprimerons tous les fichiers présent sans prévenir :

recursive: true
delete: true

@lucasmirloup
Copy link
Member Author

Merci @aegypius 😄

J'oublie pas, il faut que je m'en occupe un de ces 4 🙃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants