Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow for custom translations #237

Open
joneugster opened this issue Jun 5, 2024 · 2 comments
Open

feat: allow for custom translations #237

joneugster opened this issue Jun 5, 2024 · 2 comments
Labels
client Functionality of the client side code enhancement New feature or request fixed on dev Will be part of the next update priority-low nice to have

Comments

@joneugster
Copy link
Collaborator

We might want to allow games to provide there custom translations of the interface.

See e.g. hhu-adam/Robo#47 which asks to replace "World" by "Planet"
@joneugster joneugster added enhancement New feature or request client Functionality of the client side code priority-low nice to have labels Jun 5, 2024
@joneugster joneugster changed the title Allow for custom translations feat: allow for custom translations Jun 5, 2024
@TentativeConvert
Copy link
Collaborator

TentativeConvert commented Jun 6, 2024 •
edited
Loading

Alternatively, we could try to be agnostic and hard-code as little text as possible. Why do we need "World:" at the top of the screen to begin with? (And "World overview" in the menu could be "Game overview".)

joneugster added a commit that referenced this issue Jun 6, 2024
@joneugster
mostly remove 'world' as a word #237
80d4b88
@joneugster
Copy link
Collaborator Author

You're right, we don't need it. Changed the "world overview" to "Home" and removed the word "world" in other places.

The only appearance of "world" is now on the games' tiles on the landing page.

@joneugster joneugster added the fixed on dev Will be part of the next update label Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
client Functionality of the client side code enhancement New feature or request fixed on dev Will be part of the next update priority-low nice to have
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@joneugster @TentativeConvert