-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bad error message when tactic for filling default field value fails #2950
Labels
bug
Something isn't working
Comments
I hit this just now. Here's a Zulip discussion with an in-the-wild example, and another (not fully) minimized test case:
|
This comes up quite often, eg when using |
kmill
added a commit
to kmill/lean4
that referenced
this issue
Sep 25, 2024
Adds mechanism where when a autoparam tactic fails to synthesize a parameter, the associated parameter or field name for the autoparam is reported in an error. Notes: * Autoparams now run their tactics without any error recovery or error-to-sorry enabled. This enables catching the error and reporting the contextual information. * Autoparams for applications now cleanup the autoParam annotation, brining it in line with autoparams for structure fields. Closes leanprover#2950
github-merge-queue bot
pushed a commit
that referenced
this issue
Sep 27, 2024
Adds a mechanism where when an autoparam tactic fails to synthesize a parameter, the associated parameter name or field name for the autoparam is reported in an error. Examples: ```text could not synthesize default value for parameter 'h' using tactics could not synthesize default value for field 'inv' of 'S' using tactics ``` Notes: * Autoparams now run their tactics without any error recovery or error-to-sorry enabled. This enables catching the error and reporting the contextual information. This is justified on the grounds that autoparams are not interactive. * Autoparams for applications now cleanup the autoParam annotation, bringing it in line with autoparams for structure fields. * This preserves the old behavior that autoparams leave terminfo, but we will revisit this after some imminent improvements to the unused variable linter. Closes #2950
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The error should say that Lean failed to initialize field
inv
using the specified tactic.The text was updated successfully, but these errors were encountered: