Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a code suggestion bug #4455

Closed
3 tasks done
fonqL opened this issue Jun 14, 2024 · 2 comments · Fixed by #5257
Closed
3 tasks done

a code suggestion bug #4455

fonqL opened this issue Jun 14, 2024 · 2 comments · Fixed by #5257
Labels
bug Something isn't working P-high We will work on this issue server Affects the Lean server code

Comments

@fonqL
Copy link

fonqL commented Jun 14, 2024

Prerequisites

Please put an X between the brackets as you perform the following steps:

Description

def aaaaa := 1

#eval ([1,2,3].map λ c => a).length

When I type a in the lambda, LSP only suggests the symbols in the namespace of List, not global symbols.

Context

Zulip discussion

Steps to Reproduce

  1. Paste the code above in vscode.
  2. Put the cursor in the character a in the lambda.
  3. Trigger suggestion.

Expected behavior:

Show global symbols, including aaaaa.

Actual behavior: [Clear and concise description of what actually happens]

Only show symbols in List namespace.
Snipaste_2024-06-14_15-32-05

Versions

4.9.0-rc1

Additional Information

Impact

Add 👍 to issues you consider important. If others are impacted by this issue, please ask them to add 👍 to it.

@fonqL fonqL added the bug Something isn't working label Jun 14, 2024
@fonqL
Copy link
Author

fonqL commented Jun 14, 2024

Sorry, I seems to report in a wrong place..

@fonqL fonqL closed this as completed Jun 14, 2024
@mhuisi
Copy link
Contributor

mhuisi commented Jun 14, 2024

No, I think this is the right place!

@mhuisi mhuisi reopened this Jun 14, 2024
@mhuisi mhuisi added the server Affects the Lean server code label Jun 14, 2024
@leanprover-bot leanprover-bot added the P-high We will work on this issue label Aug 9, 2024
github-merge-queue bot pushed a commit that referenced this issue Sep 10, 2024
Fixes #4455, fixes #4705, fixes #5219

Also fixes a minor bug where a dot in brackets would report incorrect
completions instead of no completions.

---------

Co-authored-by: Sebastian Ullrich <[email protected]>
tobiasgrosser pushed a commit to opencompl/lean4 that referenced this issue Sep 16, 2024
Fixes leanprover#4455, fixes leanprover#4705, fixes leanprover#5219

Also fixes a minor bug where a dot in brackets would report incorrect
completions instead of no completions.

---------

Co-authored-by: Sebastian Ullrich <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working P-high We will work on this issue server Affects the Lean server code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants