Exception.isMaxHeartbeat no longer works

[eric-wieser]

Prerequisites

Please put an X between the brackets as you perform the following steps:

• Check that your issue is not already filed:
  https://github.com/leanprover/lean4/issues
• Reduce the issue to a minimal, self-contained, reproducible test case.
  Avoid dependencies to Mathlib or Batteries.
• Test your test case against the latest nightly release, for example on
  https://live.lean-lang.org/#project=lean-nightly
  (You can also use the settings there to switch to “Lean nightly”)

Description

Exception.isMaxHeartbeats returns false on the exception thrown by Lean.Core.throwMaxHeartbeat

Context

This means that try/catch now catches heartbeat errors, which means many tactics now ignore the heartbeat counter.

Steps to Reproduce

1. Run

import Lean

run_meta
  try
    Lean.Core.throwMaxHeartbeat `foo `bar 200
  catch e =>
    Lean.logWarning m!"{e.toMessageData}"
    unless e.isMaxHeartbeat do
      throwError "oh no"

Expected behavior: The exception should not be caught

Actual behavior: A heartbeat exception is thrown, but e.isMaxHeartbeat returns false.

Versions

• 4.11.0
• 4.12.0-nightly-2024-10-01

Additional Information

[Additional information, configuration or data that might be necessary to reproduce the issue]

Impact

Add 👍 to issues you consider important. If others are impacted by this issue, please ask them to add 👍 to it.