Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: more idiomatic syntax for if h: #5567

Merged
merged 5 commits into from
Oct 1, 2024
Merged

refactor: more idiomatic syntax for if h: #5567

merged 5 commits into from
Oct 1, 2024

Conversation

nomeata
Copy link
Contributor

@nomeata nomeata commented Oct 1, 2024

#5552 introduced a fair number
of if h:, but the slightly preferred style is if h :, with a space,
so here goes a quick sed.

@nomeata
refactor: more idiomatic syntax for if h:
c3a2b5c 
#5552 introduced a fair number
of `if h:`, but the slightly preferred style is `if h :`, with a space,
so here goes a quick `sed`.
@nomeata nomeata enabled auto-merge October 1, 2024 15:12
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc October 1, 2024 15:19 Inactive
@nomeata nomeata added this pull request to the merge queue Oct 1, 2024
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Oct 1, 2024
@leanprover-community-bot
Copy link
Collaborator

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase d4195c2605e92d583bfec8c829d845c9703800dc --onto 5e8718dff9d7906e1d4ca7020256dae7c05e49c2. (2024-10-01 15:27:04)

Merged via the queue into master with commit 60096e7 Oct 1, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhuisi mhuisi mhuisi approved these changes

@hargoniX hargoniX Awaiting requested review from hargoniX hargoniX is a code owner

@kmill kmill Awaiting requested review from kmill kmill is a code owner

@leodemoura leodemoura Awaiting requested review from leodemoura leodemoura is a code owner

@tydeu tydeu Awaiting requested review from tydeu tydeu is a code owner

Assignees
No one assigned
Labels
toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nomeata @leanprover-community-bot @mhuisi