chore: remove SplitIf.ext cache
#5571
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
!bench |
github-actions
bot
added
the
toolchain-available
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Oct 1, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Oct 1, 2024
|
Here are the benchmark results for commit 7c29c3f. Benchmark Metric Change
===================================================
+ import Lean task-clock -7.8% (-21.8 σ)
+ import Lean wall-clock -7.8% (-23.0 σ)
+ nat_repr branches -1.8% (-1213.0 σ)
- stdlib fix level params 1.2% (38.0 σ) |
|
Mathlib CI status (docs):
|
leanprover-community-bot
added
the
builds-mathlib
|
Mathlib bench is insignificant as well: http://speed.lean-fro.org/mathlib4/run-detail/736f134c-465b-45d6-b096-bb5f2f5ac81c |
Kha
commented
Oct 8, 2024
|
|
||
| namespace Lean | ||
|
|
||
| structure LazyInitExtension (m : Type → Type) (α : Type) where |
There was a problem hiding this comment.
@leodemoura I removed this abstraction as it's now unused and doing lazy initialization in an elaboration monad seems like a bad idea in general under parallelism as the elaboration context will not be deterministic. Sounds good?
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Oct 8, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Oct 8, 2024
|
Mathlib CI status (docs):
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Incompatible as is with parallelism; let's first check if it has any impact at all