Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: induction-friendly List.min?_cons #5594

Merged
merged 2 commits into from
Oct 2, 2024
Merged

chore: induction-friendly List.min?_cons #5594

merged 2 commits into from
Oct 2, 2024

Conversation

TwoFX
Copy link
Member

@TwoFX TwoFX commented Oct 2, 2024

@kim-em, I'm happy to keep any subset of foldl_min, foldl_min_right, foldl_min_le, foldl_min_min_of_le (should that one have been called foldl_min_le_of_le?). Which ones do you like?

@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc October 2, 2024 09:07 Inactive
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Oct 2, 2024
@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented Oct 2, 2024 •
edited
Loading

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase d0ee9d012774d4343ca2078b19adb11b10940fe0 --onto 5e8718dff9d7906e1d4ca7020256dae7c05e49c2. (2024-10-02 09:08:53)
  • ✅ Mathlib branch lean-pr-testing-5594 has successfully built against this PR. (2024-10-02 12:05:14) View Log

@kim-em
Copy link
Collaborator

kim-em commented Oct 2, 2024

I like foldl_min. The rest do seem a bit lame, and I guess can go.

@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc October 2, 2024 11:05 Inactive
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Oct 2, 2024
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#5594
2c21d40
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Oct 2, 2024
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#5594
3d37ea8
@leanprover-community-bot leanprover-community-bot added the builds-mathlib CI has verified that Mathlib builds against this PR label Oct 2, 2024
@TwoFX TwoFX added this pull request to the merge queue Oct 2, 2024
Merged via the queue into master with commit 09dfe1c Oct 2, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
builds-mathlib CI has verified that Mathlib builds against this PR toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TwoFX @leanprover-community-bot @kim-em