Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: reduce Reservoir build fetch attempts & warnings #5600

Merged
merged 1 commit into from
Oct 3, 2024
Merged

refactor: reduce Reservoir build fetch attempts & warnings #5600

merged 1 commit into from
Oct 3, 2024

Conversation

tydeu
Copy link
Member

@tydeu tydeu commented Oct 2, 2024

Lake no longer attempts to fetch the Reservoir build cache if the build directory is already present. Plus, failure of the automatic fetch now only produces a trace message, not a warning.

@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Oct 2, 2024
@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented Oct 2, 2024 •
edited
Loading

Mathlib CI status (docs):

  • ❗ Mathlib CI can not be attempted yet, as the nightly-testing-2024-10-02 tag does not exist there yet. We will retry when you push more commits. If you rebase your branch onto nightly-with-mathlib, Mathlib CI should run now. (2024-10-02 23:01:32)
  • 🟡 Mathlib branch lean-pr-testing-5600 build against this PR was cancelled. (2024-10-03 01:27:57) View Log
  • 🟡 Mathlib branch lean-pr-testing-5600 build against this PR was cancelled. (2024-10-03 01:31:34) View Log
  • ✅ Mathlib branch lean-pr-testing-5600 has successfully built against this PR. (2024-10-03 02:22:32) View Log

@tydeu tydeu added this pull request to the merge queue Oct 3, 2024
Merged via the queue into leanprover:master with commit a01166f Oct 3, 2024
13 checks passed
@tydeu tydeu deleted the lake/build-fetch-less branch October 3, 2024 01:48
@leanprover-community-bot leanprover-community-bot added the builds-mathlib CI has verified that Mathlib builds against this PR label Oct 3, 2024
kim-em added a commit that referenced this pull request Oct 4, 2024
@kim-em
Revert "refactor: reduce Reservoir build fetch attempts & warnings (#…
1cf7623 
…5600)"

This reverts commit a01166f.
kim-em added a commit that referenced this pull request Oct 4, 2024
@kim-em
Reapply "refactor: reduce Reservoir build fetch attempts & warnings (#…
01d414a 
…5600)"

This reverts commit 1cf7623.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
builds-mathlib CI has verified that Mathlib builds against this PR toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tydeu @leanprover-community-bot