Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up PR vs production configs for the deploy action #38

Open
jbusecke opened this issue Jul 5, 2023 · 4 comments
Open

Set up PR vs production configs for the deploy action #38

jbusecke opened this issue Jul 5, 2023 · 4 comments

Comments

@jbusecke
Copy link
Contributor

jbusecke commented Jul 5, 2023

We are currently building the full recipe for every commit (if a label is set).

I think we should have some things set in two different config jsons based on the event type:

  • Push to main:
    • Prune set to false
    • Set a permanent directory in leap-persistent-rofor each recipe and subfolders for each action run
  • PR:
    • Prune set to true
    • Write resulting data to temporary storage (e.g. leap-scratch)
@cisaacstern
Copy link

This could be achieved with conditionals in the workflow file (and no changes needed to the action). Or it could be a PR to the action. Either seems doable.

@jbusecke
Copy link
Contributor Author

jbusecke commented Jul 6, 2023

I would think the first option is more flexible right now? I guess we really need some more users of the action to see how we might properly generalize this?

@cisaacstern
Copy link

I would think the first option is more flexible right now?

Agreed. A relatively manageable path forward would be to use a github workflow step that conditionally exports either env vars (or workflow step outputs) based on the github event type, which can then be inserted into the pangeo-forge-runner JSON config.

@cisaacstern
Copy link

cisaacstern commented Jul 21, 2023

In leap-stc/data-management#33, I currently have the following parts of this working:

Push to main:

  • Prune set to false
  • Set a permanent directory in leap-persistent-ro for each recipe and subfolders for each action run

PR:

  • Prune set to true
  • Write resulting data to temporary storage (e.g. leap-scratch)

@jbusecke jbusecke transferred this issue from leap-stc/data-management Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants