Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve bridgeState naming for clarity #374

Open
troggy opened this issue Dec 12, 2019 · 0 comments
Open

Improve bridgeState naming for clarity #374

troggy opened this issue Dec 12, 2019 · 0 comments

Comments

@troggy
Copy link
Member

troggy commented Dec 12, 2019

bridgeState object is not representing a bridge state anymore. It rather represents the whole node's transient state + app/consensus state (what we call currentState).

Suggested to rename it like this:

  1. Rename bridgeState to nodeState or just state.
  2. Rename bridgeState.currentState to nodeState.consensusState. This object is used to generate app hashes for tendermint — nodes agree on the state of things upon it, hence the name consensusState.

nodeState.js:

nodeState = {
  ...
  consensusState: { 
    ... 
  }
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant