-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Design system not mobile responsive #107
Comments
indeed. the ugly part in the bottom is covered separately by #100 |
hii, I was wondering if I could be assigned to this issue? I'd be glad to help here :) |
Hi @practicatto, that'd be great improvement, thank you. Let me check briefly with our designers to confirm what's expected experience. |
@practicatto There will be larger re-design coming but we don't know exactly when and think that it shouldn't block this work. Our design team confirmed that we start with the same experience of side navigation panel as in Kolibri: I can assign you if you confirm you'd like to implement this. |
@MisRob Yea, sure. I'll start it tonight :) |
Great thanks a lot @practicatto |
Hi @practicatto, are you still planning to work in this? |
@MisRob I would like to work on this issue. |
Thanks @FidalMathew. The expected behavior is best described in #107 (comment). Please let me know if it's clear. |
@MisRob Would this design work? and on clicking this, we'll be able to view the side nav. Any suggestions? |
Hey @FidalMathew! It seems to me that the icon is a little big, what Icon are you using for this? Could you open a PR to have a better sense of the change and discuss better there, plase? :) |
@AlexVelezLl I didn't make much changes, just a few minute changes to know where the content is, and some changes are made using inspect element. The image is a photoshopped to place for now. Any suggestions on where to get icons from? |
You can use our |
Hi @FidalMathew, are you still planning to work on this issue or should we unassign? |
@MisRob Sorry, I have been sick lately, I would like to continue working on this issue. |
Hi @FidalMathew, first of all I hope you get well soon. No worries about the issue at all! Please take all the time you need, we will keep you assigned. I am just doing my regular check-in rounds on possibly stale issues. |
Hi @FidalMathew, I wanted to mention that Learning Equality will be closed from December 23 to January 5. |
@MisRob Is this open ? |
I went to show my wife the design principles on my phone and it looked like this.
The text was updated successfully, but these errors were encountered: