Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design system not mobile responsive #107

Open
nucleogenesis opened this issue Sep 18, 2020 · 18 comments
Open

Design system not mobile responsive #107

nucleogenesis opened this issue Sep 18, 2020 · 18 comments
Assignees
Labels
category: supporting code Implementation of the system good first issue Self-contained, straightforward, low-complexity help wanted Open source contributors welcome

Comments

@nucleogenesis
Copy link
Member

I went to show my wife the design principles on my phone and it looked like this.

417DE0FE-644A-4453-A665-100B2243691D

@indirectlylit
Copy link
Contributor

indeed.

the ugly part in the bottom is covered separately by #100

@indirectlylit indirectlylit added the category: supporting code Implementation of the system label Sep 23, 2020
@MisRob MisRob added the help wanted Open source contributors welcome label Aug 18, 2023
@practicatto
Copy link
Contributor

hii, I was wondering if I could be assigned to this issue? I'd be glad to help here :)

@MisRob
Copy link
Member

MisRob commented Apr 12, 2024

Hi @practicatto, that'd be great improvement, thank you. Let me check briefly with our designers to confirm what's expected experience.

@MisRob
Copy link
Member

MisRob commented Apr 12, 2024

@practicatto There will be larger re-design coming but we don't know exactly when and think that it shouldn't block this work. Our design team confirmed that we start with the same experience of side navigation panel as in Kolibri:

Peek 2024-04-12 18-53

I can assign you if you confirm you'd like to implement this.

@practicatto
Copy link
Contributor

@MisRob Yea, sure. I'll start it tonight :)

@MisRob
Copy link
Member

MisRob commented Apr 12, 2024

Great thanks a lot @practicatto

@MisRob
Copy link
Member

MisRob commented Jun 11, 2024

Hi @practicatto, are you still planning to work in this?

@MisRob MisRob added the good first issue Self-contained, straightforward, low-complexity label Nov 12, 2024
@FidalMathew
Copy link
Contributor

@MisRob I would like to work on this issue.

@MisRob
Copy link
Member

MisRob commented Nov 13, 2024

Thanks @FidalMathew. The expected behavior is best described in #107 (comment). Please let me know if it's clear.

@FidalMathew
Copy link
Contributor

Image

@MisRob Would this design work? and on clicking this, we'll be able to view the side nav. Any suggestions?

@AlexVelezLl
Copy link
Member

Hey @FidalMathew! It seems to me that the icon is a little big, what Icon are you using for this? Could you open a PR to have a better sense of the change and discuss better there, plase? :)

@FidalMathew
Copy link
Contributor

FidalMathew commented Nov 13, 2024

@AlexVelezLl I didn't make much changes, just a few minute changes to know where the content is, and some changes are made using inspect element. The image is a photoshopped to place for now. Any suggestions on where to get icons from?

@AlexVelezLl
Copy link
Member

You can use our KIcon component, and use our menu icon https://design-system.learningequality.org/icons/#token-menu, here you can see an example: https://github.com/AlexVelezLl/kolibri-design-system/blob/ab6dc8f06c89e78887bd686fa1ba8e707db43a05/docs/common/DocsToggleButton.vue#L4

@MisRob
Copy link
Member

MisRob commented Dec 9, 2024

Hi @FidalMathew, are you still planning to work on this issue or should we unassign?

@FidalMathew
Copy link
Contributor

@MisRob Sorry, I have been sick lately, I would like to continue working on this issue.

@MisRob
Copy link
Member

MisRob commented Dec 9, 2024

Hi @FidalMathew, first of all I hope you get well soon.

No worries about the issue at all! Please take all the time you need, we will keep you assigned. I am just doing my regular check-in rounds on possibly stale issues.

@FidalMathew FidalMathew mentioned this issue Dec 10, 2024
8 tasks
@MisRob
Copy link
Member

MisRob commented Dec 17, 2024

@Flying-Pegasus
Copy link

@MisRob Is this open ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: supporting code Implementation of the system good first issue Self-contained, straightforward, low-complexity help wanted Open source contributors welcome
Projects
None yet
Development

No branches or pull requests

7 participants