-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve browser history integration with the navigation Table of Contents (ToC) filter #213
Comments
The issue here can be replicated by:
This is relatively low-impact, but would be an improvement in any case. |
Assign it me please. @MisRob @indirectlylit @nucleogenesis |
Hi @RONAK-AI647! I Will assign this to you. Please let us know if you have any questions. Please take a look at the code changes of #209 for more context of the current implementation. |
As much I can see , the problem is the the nav-search filter bar does not get clear even after pressing browsers back button . Here I made some changes , but it yet requires to click the back button twice, it should be cleared as soon as the page is left, right??? Screen.Recording.2024-11-27.224917.mp4 |
Hi @RONAK-AI647! No, this is the expected haviour. You can see in the example table in the issue description that two back actions are needed to clear the filter. So this is the correct behaviour! :) |
Means I got it , should I raise a PR |
Yes! Please raise a PR 🤗. |
20241130-1437-21.0790526.mp4@AlexVelezLl and maintainers , please notice this behavior , the last clip I shared showed the desired behaviors but I wonder it behave differently now . It performs the first three actions of the table below but the last one is not executing . I don't know whats going wrong , have not even changed anything since the last commit. |
Thank you everyone , the issue is dealt , I raised a PR . |
Hi @RONAK-AI647, I wanted to mention that Learning Equality will be closed from December 23 to January 5. |
Desired behavior
Follow up from #209 (review)
Persist trailing debounced changes (wait time ~2s) to the filter as query string changes and push them onto the browser history stack.
For example:
/
/?filter=button
/kbutton?filter=button
KButton
entry/?filter=button
/
Current behavior
search filter persists indefinitely after hittting the back button, which can be surprising
(Optional) The Value Add
Simple way to navigate both pages and ToC filter using standard browser behaviors
(Optional) Possible Tradeoffs
More items added to browser history stack. Might want to update
title
with filter info so there aren't confusing duplicatesThe text was updated successfully, but these errors were encountered: