Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace or augment KTooltip slot with a text prop #221

Closed
indirectlylit opened this issue Apr 20, 2021 · 7 comments
Closed

Replace or augment KTooltip slot with a text prop #221

indirectlylit opened this issue Apr 20, 2021 · 7 comments
Assignees
Labels
category: library Shared code library Component: KTooltip good first issue Self-contained, straightforward, low-complexity help wanted Open source contributors welcome

Comments

@indirectlylit
Copy link
Contributor

indirectlylit commented Apr 20, 2021

Desired behavior

All examples I can find have plain text as the tooltip content. Therefore we should make a text prop the recommended way of passing in text:

<KTooltip
  reference="something"
  :refs="$refs"
  :text="someText"
/>

See also: #183

Current behavior

Requires use of a verbose slot:

<KTooltip
  reference="something"
  :refs="$refs"
>
  {{ someText }}
</KTooltip>

(Optional) The Value Add

Cleaner, more consistent API

@indirectlylit indirectlylit added category: docs content Design patterns and component usage category: library Shared code library type: proposal New feature or request labels Apr 20, 2021
@MisRob
Copy link
Member

MisRob commented Aug 31, 2022

I'd suggest keeping the slot - if we ever need to pass HTML content via slots, it's good to have this option. But we can, for sure, add an option to pass text via property. Some other KDS components support both ways, so it's something that I would expect in regard to consistency.

@MisRob MisRob added Component: KTooltip tag: beginner friendly and removed category: docs content Design patterns and component usage labels Aug 31, 2022
@SandhyaR1007
Copy link

Hi is this issue still open? If yes I would like to work on this.

@MisRob
Copy link
Member

MisRob commented Feb 1, 2023

Hello @SandhyaR1007, thank you for your interest in contributing. Yes, you're welcome to take it on. As soon as you start working on it, it'd be helpful if you posted a comment and I will assing you.

@MisRob MisRob removed type: proposal New feature or request tag: beginner friendly labels Aug 18, 2023
@MisRob MisRob added good first issue Self-contained, straightforward, low-complexity help wanted Open source contributors welcome labels Dec 15, 2023
@FidalMathew
Copy link
Contributor

@MisRob can I work on this issue?

@MisRob
Copy link
Member

MisRob commented Jan 26, 2024

Hi @FidalMathew, thank you for volunteering! Yes, please add text property as a simpler alternative to the slot.

@FidalMathew
Copy link
Contributor

Hi @MisRob and @LianaHarris360,
Can we close this issue? I think it's resolved.

@LianaHarris360
Copy link
Member

Yes, we can close this issue now. Thank you for bringing it to our attention. Closed by #535

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: library Shared code library Component: KTooltip good first issue Self-contained, straightforward, low-complexity help wanted Open source contributors welcome
Projects
None yet
Development

No branches or pull requests

5 participants