-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace or augment KTooltip slot with a text prop #221
Comments
I'd suggest keeping the slot - if we ever need to pass HTML content via slots, it's good to have this option. But we can, for sure, add an option to pass text via property. Some other KDS components support both ways, so it's something that I would expect in regard to consistency. |
Hi is this issue still open? If yes I would like to work on this. |
Hello @SandhyaR1007, thank you for your interest in contributing. Yes, you're welcome to take it on. As soon as you start working on it, it'd be helpful if you posted a comment and I will assing you. |
@MisRob can I work on this issue? |
Hi @FidalMathew, thank you for volunteering! Yes, please add |
Hi @MisRob and @LianaHarris360, |
Yes, we can close this issue now. Thank you for bringing it to our attention. Closed by #535 |
Desired behavior
All examples I can find have plain text as the tooltip content. Therefore we should make a
text
prop the recommended way of passing in text:See also: #183
Current behavior
Requires use of a verbose slot:
(Optional) The Value Add
Cleaner, more consistent API
The text was updated successfully, but these errors were encountered: