Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KImg: Kolibri Fly! #373

Closed
2 tasks
MisRob opened this issue Sep 22, 2022 · 5 comments
Closed
2 tasks

KImg: Kolibri Fly! #373

MisRob opened this issue Sep 22, 2022 · 5 comments
Assignees
@ShivangRawat30
Labels
category: library Shared code library good first issue Self-contained, straightforward, low-complexity help wanted Open source contributors welcome P3 - low Priority: Stretch goal

Comments

@MisRob
Copy link
Member

MisRob commented Sep 22, 2022 •
edited
Loading

Summary

Truthy kolibriFly prop renders the Kolibri logo into the KImg. This overrides the src specified

Epic

Acceptance criteria

  • Setting kolibriFly to true renders the Kolibri logo into the component
  • Any set src is overridden

Linked issues
@MisRob MisRob mentioned this issue Sep 22, 2022
Closed
7 tasks
@akolson akolson mentioned this issue Sep 22, 2022
Closed
5 tasks
@MisRob MisRob mentioned this issue Sep 22, 2022
Closed
6 tasks
@MisRob MisRob changed the title [TBD] KImg: Kolibri Fly! KImg: Kolibri Fly! Sep 23, 2022
@MisRob
Copy link
Member Author

MisRob commented Sep 23, 2022

Some KDS and products source files with the logo

@MisRob MisRob added P3 - low Priority: Stretch goal help wanted Open source contributors welcome good first issue Self-contained, straightforward, low-complexity labels Aug 18, 2023
@ShivangRawat30
Copy link
Contributor

I would like to work on this issue.

@MisRob
Copy link
Member Author

MisRob commented Sep 25, 2023

Hi @ShivangRawat30, good choice, this is IMHO the most fun issue in KDS. I'm sure that the team will love it :)

@ShivangRawat30 ShivangRawat30 mentioned this issue Oct 1, 2023
Merged
8 tasks
@MisRob
Copy link
Member Author

MisRob commented Oct 20, 2023

Note that the specification here was changed to creating a new component, KLogo instead. #460 (review)

@MisRob
Copy link
Member Author

MisRob commented Oct 23, 2023

Closed by #460

@MisRob MisRob closed this as completed Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ShivangRawat30 ShivangRawat30

Labels
category: library Shared code library good first issue Self-contained, straightforward, low-complexity help wanted Open source contributors welcome P3 - low Priority: Stretch goal
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MisRob @ShivangRawat30