-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#Update Docs for z-index & drop-shadow for better clarity #819
#Update Docs for z-index & drop-shadow for better clarity #819
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The documentation changes LGTM - I think that your linting issue might be directly related to the changelog issue -- however, to me your changelog section looks right so I'm wondering if maybe @MisRob might see something I'm missing there.
Thank you @RONAK-AI647 for your work on this!
I'm not sure why the linter check is failing. Sometimes I need to run |
@RONAK-AI647 @nucleogenesis another issue is that this PR contains updated |
This reverts commit 0d8ea89.
@MisRob please take a look what my terminal output is: |
Thank you @RONAK-AI647, I don't understand why that's happening. I could see an update made by the linter so I went ahead and pushed the change for you. |
Thank you @MisRob for the help , the local server is passing the linter check but it is not passing here in the cicd, i was struggling for it so much. |
You're welcome @RONAK-AI647, sorry for the trouble :) |
Anything else here @nucleogenesis or could we merge now? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again for this @RONAK-AI647 !
Description
The Google Material Design elevation image is not relevant to our approach to drop-shadows, so it should be moved down to the "z-index" section where it is more relevant.
Issue addressed
#813
Addresses #*PR# #819
Before/after screenshots
Changelog
Steps to test
(optional) Implementation notes
At a high level, how did you implement this?
Does this introduce any tech-debt items?
Testing checklist
Reviewer guidance
Comments
The google material design elevation image from dropdown menu is shifted to the z-index section as the image is more relevant there.