Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[KButton]: Add aria-haspopup and aria-expanded to KButton when it has a KDropdownMenu related #832

Open
AlexVelezLl opened this issue Nov 19, 2024 · 3 comments · May be fixed by #856
Open

[KButton]: Add aria-haspopup and aria-expanded to KButton when it has a KDropdownMenu related #832

AlexVelezLl opened this issue Nov 19, 2024 · 3 comments · May be fixed by #856
Assignees
@josephinoo
Labels
Component: KButton Component: KDropdownMenu help wanted Open source contributors welcome P2 - normal Priority: Nice to have size: small TAG: a11y

Comments

@AlexVelezLl
Copy link
Member

🌱 Are you new to the codebase? Welcome! Please see the contributing guidelines.

Product

Kolibri, Studio, KDS, etc.

Expected behavior

KButton should have the required aria-haspopup property, and the aria-expanded state when it activates a dropdown menu.

The rendered button should have aria-haspopup="menu" if it has a menu slot defined, aria-expanded="false" if the dropdown is closed, and aria-expanded="true" if the dropdown is opened.

Actual behavior

We dont have any of these properties in kbutton right now.
@AlexVelezLl AlexVelezLl mentioned this issue Nov 19, 2024
Closed
@josephinoo
Copy link

Hi @AlexVelezLl , can you assign this issue to me ?

@AlexVelezLl
Copy link
Member Author

Hi @josephinoo! For sure! Thanks for your interest in contributing to Kolibrí 🤗 . I will assign this issue to you. Let us know if you have any questions :)

@josephinoo josephinoo linked a pull request Dec 7, 2024 that will close this issue
Open
8 tasks
@MisRob
Copy link
Member

MisRob commented Dec 17, 2024

Hi @josephinoo, I wanted to mention that Learning Equality will be closed from December 23 to January 5.

@AlexVelezLl AlexVelezLl linked a pull request Jan 7, 2025 that will close this issue
KButton: Add aria-haspopup and aria-expanded for dropdown menus #856
Open
8 tasks
@AlexVelezLl AlexVelezLl removed a link to a pull request Jan 9, 2025
KButton: Add aria-haspopup and aria-expanded for dropdown menus #856
Open
8 tasks
@AlexVelezLl AlexVelezLl linked a pull request Jan 9, 2025 that will close this issue
KButton: Add aria-haspopup and aria-expanded for dropdown menus #856
Open
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@josephinoo josephinoo

Labels
Component: KButton Component: KDropdownMenu help wanted Open source contributors welcome P2 - normal Priority: Nice to have size: small TAG: a11y
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

KButton: Add aria-haspopup and aria-expanded for dropdown menus josephinoo/kolibri-design-system
3 participants
@MisRob @josephinoo @AlexVelezLl