From a7fdf5207bee24295eaaea103109011bc0977ec7 Mon Sep 17 00:00:00 2001 From: Alex Velez Date: Fri, 30 Aug 2024 09:39:18 -0500 Subject: [PATCH 1/3] Add missing changelog item --- CHANGELOG.md | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 77ef5524a..e98b2b645 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -6,6 +6,16 @@ Changelog is rather internal in nature. See release notes for the public overvie +- [#762] + - **Description:** Updates dropshadows to the latest design guidelines + - **Products impact:** Visual + - **Addresses:** https://github.com/learningequality/kolibri-design-system/issues/724 + - **Components:** All components with dropshadows + - **Breaking:** no + - **Impacts a11y:** no + - **Guidance:** - + +[#762]: https://github.com/learningequality/kolibri-design-system/pull/762 - [#722] - **Description:** Inserts the overlay container element `#k-overlay` to an application's document body during KDS initialization. From f9a423168bbd5a3fca213246d1ef3d37ce17be37 Mon Sep 17 00:00:00 2001 From: Alex Velez Date: Fri, 30 Aug 2024 09:39:54 -0500 Subject: [PATCH 2/3] Fix update changelog to avoid expecting a comment after the invisible comment --- .github/workflows/update_changelog.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/update_changelog.yml b/.github/workflows/update_changelog.yml index 8ab504ef9..992ca0ec7 100644 --- a/.github/workflows/update_changelog.yml +++ b/.github/workflows/update_changelog.yml @@ -29,7 +29,7 @@ jobs: changelog = " - **Description:** ${{ github.event.pull_request.title }}\n - **Products impact:** Dev Dependency upgrade\n - **Addresses:** -\n - **Components:** -\n - **Breaking:** -\n - **Impacts a11y:** -\n - **Guidance:** -" else: description = """${{ github.event.pull_request.body }}""" - capture = re.compile("\s+))") + capture = re.compile("(\n|.)+?(?=- \*\*Description)(?P(\n|.)+?(?=))") match = capture.search(description) changelog = match.groupdict()["body"].strip() From 380094a635d70d99c4c3eb85eebd09614e3cfad4 Mon Sep 17 00:00:00 2001 From: Alex Velez Date: Tue, 3 Sep 2024 12:19:07 -0500 Subject: [PATCH 3/3] Remove after review check in pull request template --- .github/pull_request_template.md | 4 ---- 1 file changed, 4 deletions(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 026492ffc..41a182f83 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -63,9 +63,5 @@ Addresses #*PR# HERE* - [ ] Are all UI components LTR and RTL compliant (if applicable)? - [ ] _Add other things to check for here_ -## After review - -- [ ] The changelog item has been pasted to the `CHANGELOG.md` - ## Comments