Remove FocusTrap in favor of KFocusTrap

[MisRob]

🌱 Are you new to the codebase? Welcome! Please see the contributing guidelines.

Blocked by

• Add KFocusTrap and use it in KModal kolibri-design-system#746

Summary

As soon as Kolibri Design System contains learningequality/kolibri-design-system#746, here in Kolibri we need to

(1) Remove all FocusTraps that are wrapping KModal s

<FocusTrap>
  <KModal>

(because KModal will contain the focus trapping logic within itself)

(2) Rename all remaining instances of FocusTrap to KFocusTrap

(3) Finally remove kolibri/core/assets/src/views/FocusTrap.vue

Comments

This may slightly conflict with #5488. Nothing really blocking, let’s just inform @rtibbles about progress on this issue.

Acceptance criteria

• Implemented as specified above
• There are no regressions at all updated places

[DakshArora1004]

Hi @MisRob, I'm interested in working on this issue after kolibri-design-system#746 is resolved. Could you assign it to me? I'll start preparing and will be ready to implement once the blocker is cleared.

[MisRob]

Hi @DakshArora1004, thanks for volunteering. I will assign you. After learningequality/kolibri-design-system#764 is merged, you can use devserver-with-kds command to run Kolibri with your local Kolibri Design System. Feel free to ask any questions here.

[MisRob]

@DakshArora1004 I wanted to flag there's a possibility that this work will be addressed in the scope of learningequality/kolibri-design-system#764 (comment). Better to wait before working on what's the decision in the linked pull request.

[MisRob]

@DakshArora1004 I'm sorry for confusion but we will assign this to the same volunteer who has just resolved learningequality/kolibri-design-system#764 since they will use this issue to ensure everything works as expected in Kolibri. Otherwise both of you would work on the same task.

There are other contributing opportunities in three repositories you're very welcome to explore. See the contributing guidelines including links to issues suitable for contribution for each repository here:

• Kolibri Contributing Guidelines
• Kolibri Design System Contributing Guidelines
• Studio Contributing Guidelines

You can also see the list of unassigned "help wanted" or "good first issue" issues across all repositories.

[lokesh-sagi125]

hey @MisRob .

[MisRob]

Hi, thanks @lokesh-sagi125, assigning as agreed

[MisRob]

@lokesh-sagi125 may be handy https://kolibri-dev.readthedocs.io/en/develop/howtos/development_with_kds.html ;) cc @akolson

[MisRob]

Hi @lokesh-sagi125, are you working on this or planning to? Just to know if we should keep the assignment or not.

[lokesh-sagi125]

YES @MisRob i am still working on this issue, i was learning going through the codebase to avoid making errors while creating the component, i will raise a PR in 3 days

[MisRob]

Thanks for update @lokesh-sagi125. No problem and no pressure at all, just my regular rounds checking on possibly stale assignments.

[rtibbles]

Fixed in #12718

Thanks for your work here @lokesh-sagi125, very much appreciated!

[lokesh-sagi125]

@rtibbles thank you for helping me with the rebasing issues . i hope to produce PR's with lesser problems in the future :).