Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement language filter for channels #12702

Open
marcellamaki opened this issue Oct 3, 2024 — with Slack · 6 comments · May be fixed by #12892
Open

Implement language filter for channels #12702

marcellamaki opened this issue Oct 3, 2024 — with Slack · 6 comments · May be fixed by #12892
Assignees
Labels
APP: Learn Re: Learn App (content, quizzes, lessons, etc.) DEV: frontend

Comments

Copy link
Member

marcellamaki commented Oct 3, 2024

When on the "Explore Libraries" page, whether exploring a LAN library or Studio, a language filter should be placed in the the upper right corner of the page to make it easier to find channels by language.
image

This is distinct from doing a content search with the language filter in the side panel and returning content search results (i.e. resources).

Acceptance criteria:

  • On "Explore Libraries" page, the language filter should be moved to the top right corner of the results
  • The language filter should default to the current UI language
  • The channel cards should be filtered by language, inclusively (i.e. a channel that has multiple languages should in included in the results if any of the languages matches the filter)
@marcellamaki marcellamaki added APP: Learn Re: Learn App (content, quizzes, lessons, etc.) DEV: frontend labels Oct 3, 2024 — with Slack
@marcellamaki marcellamaki added this to the Kolibri 0.18: General maintenance milestone Oct 3, 2024 — with Slack
@marcellamaki marcellamaki added TODO: needs decisions Design or specifications are necessary and removed TODO: needs decisions Design or specifications are necessary labels Oct 3, 2024
@RONAK-AI647
Copy link

hey @marcellamaki ,This is @RONAK-A1647.I understood the issue but unable to figure out the language filter's position .On my screen ,the interface seems like this (a screenshot attached),will you please let me know the before position and where you wanna it to be shifted,

Image
i expect you want to move the language filter to the box with question mark...let me know if i am right

@MisRob
Copy link
Member

MisRob commented Oct 16, 2024

Hi @RONAK-AI647, thanks for reaching out! I will leave @marcellamaki to confirm the expected output and whether this is ready for contribution.

A note from me, if you end up working on it, please double-check if there are more usages of the sidebar component and if so, implement the solution so that the filter in question doesn't get missing from the sidebar unexpectedly in another places. Perhaps it's used just at one place - if that's the case, consider this as a general recommendation as we frequently use a single component in more places so always good to do code search.

@MisRob
Copy link
Member

MisRob commented Oct 16, 2024

Also @RONAK-AI647, it's always better to ask for an assignment at first, and generally it's issues labeled as 'help wanted' where you can be sure it's open for assignment. There are contributing opportunities in three repositories. See the contributing guidelines including links to issues suitable for contribution for each repository here:

You can also see the list of unassigned "help wanted" or "good first issue" issues across all repositories.

@RONAK-AI647
Copy link

Hey @MisRob ,thankyou so much for your advice and guidance .I am quite impressed with the motto of learning equality of making content available offline. I am checking all possible good first issues and help wanted issues where i can contribute.

@MisRob
Copy link
Member

MisRob commented Oct 17, 2024

Thanks @RONAK-AI647, we're glad to be in touch. I think there are still some free 'help wanted' so yeah that'd be best. We're regularly adding new 'help wanted', I'm planning to add some more throughout November, so it's good to check it out from time to time. I noticed some mentions - wanted to note that I'm out starting today till November 4. My colleague-friends will get to you. Be well.

@marcellamaki
Copy link
Member Author

Hi @RONAK-AI647 - yes, please look for the 'help wanted' label and then ask for issue assignment. This still needs some details added and is not ready for/open for community contribution right now. Thank you.

@rtibbles rtibbles self-assigned this Nov 19, 2024
@rtibbles rtibbles linked a pull request Nov 27, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APP: Learn Re: Learn App (content, quizzes, lessons, etc.) DEV: frontend
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants