From c4b352a1aad2b0c3ae6a0fec5cca2ea3b1632dcd Mon Sep 17 00:00:00 2001
From: yash1378 <slayycasm997@gmail.com>
Date: Fri, 22 Sep 2023 21:16:50 +0530
Subject: [PATCH 1/3] TextTruncator.vue is totally removed from the entire
 codebase

---
 .../core/assets/src/views/TextTruncator.vue   | 138 ------------------
 1 file changed, 138 deletions(-)
 delete mode 100644 kolibri/core/assets/src/views/TextTruncator.vue

diff --git a/kolibri/core/assets/src/views/TextTruncator.vue b/kolibri/core/assets/src/views/TextTruncator.vue
deleted file mode 100644
index db7e5f8d30c..00000000000
--- a/kolibri/core/assets/src/views/TextTruncator.vue
+++ /dev/null
@@ -1,138 +0,0 @@
-<template>
-
-  <div :style="{ maxHeight: `${maxHeight - 16}px` }" :class="{ truncated: !shaveDone }">
-    <div v-if="viewAllText">
-      {{ text }}
-    </div>
-    <div v-else ref="shaveEl" class="truncated">
-      {{ text }}
-    </div>
-    <div
-      v-if="showViewMore && (textIsTruncated || viewAllText)"
-      class="show-more"
-    >
-      <KButton
-        appearance="basic-link"
-        :text="viewAllText ? $coreString('viewLessAction') : coreString('viewMoreAction')"
-        @click.stop.prevent="viewAllText = !viewAllText"
-      />
-    </div>
-  </div>
-
-</template>
-
-
-<script>
-
-  import shave from 'shave';
-  import debounce from 'lodash/debounce';
-  import responsiveElementMixin from 'kolibri.coreVue.mixins.responsiveElementMixin';
-  import commonCoreStrings from 'kolibri.coreVue.mixins.commonCoreStrings';
-
-  export default {
-    name: 'TextTruncator',
-    mixins: [commonCoreStrings, responsiveElementMixin],
-    props: {
-      text: {
-        type: String,
-        required: true,
-      },
-      maxHeight: {
-        type: Number,
-        required: true,
-        validator(value) {
-          return value > 0;
-        },
-      },
-      showViewMore: {
-        type: Boolean,
-        required: false,
-        default: false,
-      },
-    },
-    data() {
-      return {
-        textIsTruncated: false,
-        shaveDone: false,
-        viewAllText: false,
-      };
-    },
-    computed: {
-      currentDimensions() {
-        return {
-          elementWidth: this.elementWidth,
-          elementHeight: this.elementHeight,
-        };
-      },
-      debouncedHandleUpdate() {
-        return debounce(this.handleUpdate, 50);
-      },
-    },
-    watch: {
-      currentDimensions() {
-        this.debouncedHandleUpdate();
-      },
-    },
-    beforeDestroy() {
-      this.debouncedHandleUpdate.cancel();
-    },
-    methods: {
-      titleIsShaved() {
-        return Boolean(this.$el.querySelector('.js-shave'));
-      },
-      titleIsOverflowing() {
-        // This checks to see if shave.js did not work, but the text is still
-        // overflowing. This can happen if `text` prop is one long string.
-        const $shaveEl = this.$refs.shaveEl;
-        if (!$shaveEl) {
-          return false;
-        } else {
-          return $shaveEl.clientWidth < $shaveEl.scrollWidth;
-        }
-      },
-      updateTitle() {
-        // Set title attribute as full text if the visible text is truncated
-        if (this.textIsTruncated && !this.$refs.shaveEl.title) {
-          this.$refs.shaveEl.setAttribute('title', this.text);
-        } else if (!this.textIsTruncated && this.$refs.shaveEl.title) {
-          // Remove if text is fully visible after a resize
-          this.$refs.shaveEl.removeAttribute('title');
-        }
-      },
-      handleUpdate() {
-        // TODO make "View Less" disappear when user expands window
-        // and text isn't truncated anymore.
-        shave(this.$refs.shaveEl, this.maxHeight, { spaces: false });
-        this.$nextTick().then(() => {
-          this.textIsTruncated = this.titleIsShaved() || this.titleIsOverflowing();
-          this.updateTitle();
-          // Removes temporary truncated styling from main div
-          this.shaveDone = true;
-        });
-      },
-    },
-  };
-
-</script>
-
-
-<style lang="scss" scoped>
-
-  .show-more {
-    margin-top: 8px;
-    text-align: right;
-  }
-
-  // If the text is a long single word (and not shortened by shave.js),
-  // then apply this CSS instead
-  .truncated {
-    overflow: hidden;
-    text-overflow: ellipsis;
-    // this ensure that when the text truncator is used
-    // in a router-link card, the text is not underlined
-    a {
-      text-decoration: none !important;
-    }
-  }
-
-</style>

From 1c9e91b283e640fc3bfbdc6f1df90e759306088c Mon Sep 17 00:00:00 2001
From: yash1378 <slayycasm997@gmail.com>
Date: Fri, 22 Sep 2023 21:36:13 +0530
Subject: [PATCH 2/3] TextTruncator.vue is totally removed from the entire
 codebase reviewed

---
 kolibri/core/assets/src/core-app/apiSpec.js | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/kolibri/core/assets/src/core-app/apiSpec.js b/kolibri/core/assets/src/core-app/apiSpec.js
index 02ee53934af..0c36eae6d01 100644
--- a/kolibri/core/assets/src/core-app/apiSpec.js
+++ b/kolibri/core/assets/src/core-app/apiSpec.js
@@ -112,7 +112,7 @@ import * as contentNode from '../utils/contentNodeUtils';
 import InteractionList from '../views/InteractionList';
 import ExamReport from '../views/ExamReport';
 import SlotTruncator from '../views/SlotTruncator';
-import TextTruncator from '../views/TextTruncator';
+// import TextTruncator from '../views/TextTruncator';
 import TextTruncatorCss from '../views/TextTruncatorCss';
 import TimeDuration from '../views/TimeDuration';
 import SuggestedTime from '../views/SuggestedTime';
@@ -182,7 +182,7 @@ export default {
       InteractionList,
       ExamReport,
       SlotTruncator,
-      TextTruncator,
+      // TextTruncator,
       TextTruncatorCss,
       TimeDuration,
       MultiPaneLayout,

From 41e64c6d4e32420a3fa2ac5e3df49553050942d0 Mon Sep 17 00:00:00 2001
From: yash <slayycasm997@gmail.com>
Date: Mon, 25 Sep 2023 21:22:58 +0530
Subject: [PATCH 3/3] feedback correction is made

---
 kolibri/core/assets/src/core-app/apiSpec.js | 2 --
 1 file changed, 2 deletions(-)

diff --git a/kolibri/core/assets/src/core-app/apiSpec.js b/kolibri/core/assets/src/core-app/apiSpec.js
index 0c36eae6d01..58e70722fd2 100644
--- a/kolibri/core/assets/src/core-app/apiSpec.js
+++ b/kolibri/core/assets/src/core-app/apiSpec.js
@@ -112,7 +112,6 @@ import * as contentNode from '../utils/contentNodeUtils';
 import InteractionList from '../views/InteractionList';
 import ExamReport from '../views/ExamReport';
 import SlotTruncator from '../views/SlotTruncator';
-// import TextTruncator from '../views/TextTruncator';
 import TextTruncatorCss from '../views/TextTruncatorCss';
 import TimeDuration from '../views/TimeDuration';
 import SuggestedTime from '../views/SuggestedTime';
@@ -182,7 +181,6 @@ export default {
       InteractionList,
       ExamReport,
       SlotTruncator,
-      // TextTruncator,
       TextTruncatorCss,
       TimeDuration,
       MultiPaneLayout,