Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making contract calls with Ledger doesn't broadcast transactions after they're signed #2585

Closed
2snEM6 opened this issue Jul 21, 2022 · 3 comments

Comments

@2snEM6
Copy link

2snEM6 commented Jul 21, 2022

How to reproduce

Call openContractCall. Example:

openContractCall({
        contractAddress,
        contractName,
        functionName: 'delegate-stx',
        functionArgs: [...args],
        onFinish: () => {
          console.log('onFinish')
        },
      });

Sign the transaction with Ledger, wallet will say it's approved, but nothing will happen afterwards and onFinish will not be called.

@fbwoolf
Copy link
Contributor

fbwoolf commented Jul 21, 2022

I believe we determined this was a broadcast error not being displayed in the wallet. BadFunctionArgument which is going to be added in this work here: #2582 ...so, I am going to close this issue.

image

@fbwoolf fbwoolf closed this as completed Jul 21, 2022
@fbwoolf
Copy link
Contributor

fbwoolf commented Jul 21, 2022

Also, this issue was created in Connect: hirosystems/connect#261

@2snEM6
Copy link
Author

2snEM6 commented Jul 21, 2022

Agree, will follow #2582, thanks @fbwoolf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants