Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lh5concat silently drops data it can't merge #119

Open
ManuelHu opened this issue Nov 13, 2024 · 0 comments
Open

lh5concat silently drops data it can't merge #119

ManuelHu opened this issue Nov 13, 2024 · 0 comments
Labels
bug Something isn't working lh5 HDF5 I/O

Comments

@ManuelHu
Copy link
Contributor

background: after legend-exp/remage#152 remage produces LH5 with tables nested into a top-level struct.

After testing with those files, @gipert found that lh5concat does nothing at all when working on those files. (*)

  1. lh5concat does not merge all LGDO types, e.g. structs
    of course this can only be fixed for "group-like" structs (i.e. normal HDF5 group with a set datatype attr, only containing Array-like datasets or other groups/group-like structs)
  2. but it also does not warn about data being "discarded" or not included in this process.
    this is escpecially bad as the user does not see anything from this error condition, and might wonder why nothing happened or why data is missing from merged files.
@gipert gipert added bug Something isn't working lh5 HDF5 I/O labels Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lh5 HDF5 I/O
Projects
None yet
Development

No branches or pull requests

2 participants